search

pbauerochse / searchable-option-list

a jquery plugin for a searchable optionlist
MIT License
79 stars 54 forks source link

sol works great in android but doesnt position properly on ios #32

Open northeastrc opened 8 years ago

northeastrc commented 8 years ago

Thanks this works awesome on android however it doesn't position itself correctly on ios is there something i am missing i am still very new to this programming stuff the results box sometimes is off screen and sometimes it covers the input box update this only happens when one has been selected and you attempt to select another item

pbauerochse commented 8 years ago

Unfortunately I don't have an iOS device so I can't really test this for now. The positioning of the container is quite tricky. I will see if I can get my hands on an iOS device soon. If anyone else is seeing this on iOS and is experienced in programming, a pull request would be much appreciated.

northeastrc commented 8 years ago

Thank you On May 9, 2016 3:58 AM, "pbauerochse" notifications@github.com wrote:

Unfortunately I don't have an iOS device so I can't really test this for now. The positioning of the container is quite tricky. I will see if I can get my hands on an iOS device soon. If anyone else is seeing this on iOS and is experienced in programming, a pull request would be much appreciated.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/pbauerochse/searchable-option-list/issues/32#issuecomment-217799634

northeastrc commented 8 years ago

Awsome code Thank you When positioning the container do you look at the whole page or just inside the div after thinking about it that may be my problem when it first loads I have no text below the container after selecting I have paragraphs I will try clearing the text tonight and see if that fixes it. Again very cool code thanks Ron On May 9, 2016 5:23 AM, "Ron Cote" roncote1@gmail.com wrote:

Thank you On May 9, 2016 3:58 AM, "pbauerochse" notifications@github.com wrote:

Unfortunately I don't have an iOS device so I can't really test this for now. The positioning of the container is quite tricky. I will see if I can get my hands on an iOS device soon. If anyone else is seeing this on iOS and is experienced in programming, a pull request would be much appreciated.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/pbauerochse/searchable-option-list/issues/32#issuecomment-217799634

pbauerochse commented 8 years ago

There is an option called scrollTarget which in most cases is defaulted to the browser window (see https://github.com/pbauerochse/searchable-option-list/blob/master/sol.js#L158) but may be overridden by the user to adapt to their needs (e.g. fixed headers, overflow: auto containers etc).

This is the element, the scroll event listener gets attached to and which is also taken into calculation in the onScroll event at https://github.com/pbauerochse/searchable-option-list/blob/master/sol.js#L72

This is where all the positionining magic is happening. That's also the part that was causing most of the headaches when programming SOL ;) I must admit that this is also the part which I am the least proud of because it could use some modularization so it would be easier to read

northeastrc commented 8 years ago

I think that clearing the paragraph text is gonna fix it i will try tonight. awsome code I have an option box with over 1900 entries and it works amazing except for the position and now I have a place to look thank you so much Ron On May 9, 2016 11:34 AM, "pbauerochse" notifications@github.com wrote:

There is an option called scrollTarget which in most cases is defaulted to the browser window (see https://github.com/pbauerochse/searchable-option-list/blob/master/sol.js#L158) but may be overridden by the user to adapt to their needs (e.g. fixed headers, overflow: auto containers etc).

This is the element, the scroll event listener gets attached to and which is also taken into calculation in the onScroll event at https://github.com/pbauerochse/searchable-option-list/blob/master/sol.js#L72

This is where all the positionining magic is happening. That's also the part that was causing most of the headaches when programming SOL ;) I must admit that this is also the part which I am the least proud of because it could use some modularization so it would be easier to read

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/pbauerochse/searchable-option-list/issues/32#issuecomment-217899974