pbca26 / agama-mobile

Agama Wallet Mobile
Other
5 stars 30 forks source link

[Account creation / Import] - Feature request. Add copy to clipboard button for seed and save to file button for QR. #26

Closed tonymorony closed 5 years ago

tonymorony commented 5 years ago

create_seed

At the moment there is no way to save this data except manual selecting, moreover, such manual selecting allows to grab extra space.

Copy to clipboard button will allow the user to reliable copy his seed + in future will be possible to add validation with "I'm saved seed" tick where the user has to paste his seed to confirm the match before next step proceeds.

Also not sure that many users know how to do manually screenshot from their phone to save the seed.

Extra space: extra_space

pbca26 commented 5 years ago

s90301-115406 this is what i have, no extra space have you checked after copy-pasting that it does actually contain an extra space or is it just a rendering issue?

tonymorony commented 5 years ago

On paste it had extra /n

On Fri, Mar 1, 2019, 15:58 pbca26 notifications@github.com wrote:

[image: s90301-115406] https://user-images.githubusercontent.com/7769879/53627309-2f7bc400-3c19-11e9-98ee-3cd743ef80e7.jpg this is what i have, no extra space have you checked after copy-pasting that it does actually contain an extra space or is it just a rendering issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pbca26/agama-mobile/issues/26#issuecomment-468592956, or mute the thread https://github.com/notifications/unsubscribe-auth/AXpiAz79lRElgiPseKwLg14xVGI1-5jjks5vSOungaJpZM4bYDDn .

tonymorony commented 5 years ago

video: https://s3.us-east-2.amazonaws.com/tonyl777/seed_copy_paste.mp4

actually, it's possible to copy a content of the whole page (selector not locking on the field with seed) - just noticed. So I wonder you just select it carefully.

tonymorony commented 5 years ago

Realized now that it'll not help much if the user will paste it with an error then.

Maybe in future, it'll be possible to make this process as in BitPay wallet: you no need to input pre-generated seed on the first login but can export it later or on creation process if click export button. It helps to avoid the problem when users initially sending funds to the address generated by misspelled seed pasting (more than half of Agama desktop support tickets regards such problem)

pbca26 commented 5 years ago

that makes sense although i'm a fan of ledger's seed confirm flow

tonymorony commented 5 years ago

Process was improved with words confirmation + only seed is selectable