pbclife / gitopener.vercel.app

Git Opener is a learning web app if you are looking forward to get started with open source then you are in right place. Please read contribution guideline.
https://gitopener.vercel.app
MIT License
47 stars 32 forks source link

DOC: Need to add how to find SVG icons code #126

Closed priyankarpal closed 1 year ago

priyankarpal commented 1 year ago

In the documentation, we need to add how a user can find the SVG icons code

image

ArslanYM commented 1 year ago

Can I work on this?

priyankarpal commented 1 year ago

Can I work on this?

Yeah sure. Assigned to you.

ArslanYM commented 1 year ago

Cool on it

ArslanYM commented 1 year ago

@priyankarpal Like this right? image

priyankarpal commented 1 year ago

@priyankarpal Like this right? image

yeah.Looks Good 🎉 also share whole doc

ArslanYM commented 1 year ago

@priyankarpal also the guide should just state how to copy and paste svgs , not what svgs are etc?

priyankarpal commented 1 year ago

@priyankarpal also the guide should just state how to copy and paste svgs , not what svgs are etc?

yes. how to copy the code & paste.

ArslanYM commented 1 year ago

Hey , I'm not getting the option for creating a PR?

priyankarpal commented 1 year ago

Hey , I'm not getting the option for creating a PR?

why? are you in the code editor?

ArslanYM commented 1 year ago

Hey , I'm not getting the option for creating a PR?

why? are you in the code editor?

I did the normal procedure , made a new branch , did my changes , commited and pushed to the new branch on my fork. But the change is not displaying for some reason

priyankarpal commented 1 year ago

Hey , I'm not getting the option for creating a PR?

why? are you in the code editor?

I did the normal procedure , made a new branch , did my changes , commited and pushed to the new branch on my fork. But the change is not displaying for some reason

have you ever set upstream command?

ArslanYM commented 1 year ago

yeah i set the upstream command as well

priyankarpal commented 1 year ago

yeah i set the upstream command as well

could you share screenshots?

ArslanYM commented 1 year ago

commit: commm

I think this is the issue. Im making the changes but they arent being commited because of lint error. Can you tell me how i should write the commit code. I am not familiar with husky

priyankarpal commented 1 year ago

commit: commm

I think this is the issue. Im making the changes but they arent being commited because of lint error. Can you tell me how i should write the commit code. I am not familiar with husky

you need to add a proper title. such as "docs: added svg icon page"

ArslanYM commented 1 year ago

commit: commm I think this is the issue. Im making the changes but they arent being commited because of lint error. Can you tell me how i should write the commit code. I am not familiar with husky

you need to add a proper title. such as "docs: added svg icon page"

another

still not working

priyankarpal commented 1 year ago

@sboy99 please check

sboy99 commented 1 year ago

use docs: instead of docs :

suzy-g38 commented 1 year ago

@ArslanYM if your problem is solved congrats otherwise, you can follow this document, which helped me: https://www.conventionalcommits.org/en/v1.0.0-beta.2/#why-use-conventional-commits.

suzy-g38 commented 1 year ago

@sboy99 @priyankarpal don't you think adding some examples in the "How to write professional commits ?" section, can give some extra clarity?

sboy99 commented 1 year ago

@sboy99 @priyankarpal don't you think adding some examples in the "How to write professional commits ?" section, can give some extra clarity?

Yes that is also a part of the documentation create a folder inside guides best practice and we can write best practices as well

suzy-g38 commented 1 year ago

@sboy99 @priyankarpal don't you think adding some examples in the "How to write professional commits ?" section, can give some extra clarity?

Yes that is also a part of the documentation create a folder inside guides best practice and we can write best practices as well

Why create another folder when we can add them in the "How to write professional commits. mdx" file. Because if you check the "Here are some examples of good commit messages:" part those are actually the definitions of the terminology we use mostly like feat, fix, docs etc, but not the examples of commit messages. So if you create a part like "definitions of the terminologies" and then examples, don't you think that will be a good option?

sboy99 commented 1 year ago

Professional commits are useful to identify the type of work or change is being made. Additionally it supports automated releases. In software development most of the changes can be broken down into adding features fixing bugs doing a task performance optimization ci cd etc. So to trigger this you can break your commit message into two.

sub: message

In the field of subject you can and conventions such as feat fix chore refactor etc. You can better check in the commitlint file. And followed by a suitable message. Thats it.

sboy99 commented 1 year ago

Di

@sboy99 @priyankarpal don't you think adding some examples in the "How to write professional commits ?" section, can give some extra clarity?

Yes that is also a part of the documentation create a folder inside guides best practice and we can write best practices as well

Why create another folder when we can add them in the "How to write professional commits. mdx" file. Because if you check the "Here are some examples of good commit messages:" part those are actually the definitions of the terminology we use mostly like feat, fix, docs etc, but not the examples of commit messages. So if you create a part like "definitions of the terminologies" and then examples, don't you think that will be a good option?

Yup, we can do that as well

suzy-g38 commented 1 year ago

Di

@sboy99 @priyankarpal don't you think adding some examples in the "How to write professional commits ?" section, can give some extra clarity?

Yes that is also a part of the documentation create a folder inside guides best practice and we can write best practices as well

Why create another folder when we can add them in the "How to write professional commits. mdx" file. Because if you check the "Here are some examples of good commit messages:" part those are actually the definitions of the terminology we use mostly like feat, fix, docs etc, but not the examples of commit messages. So if you create a part like "definitions of the terminologies" and then examples, don't you think that will be a good option?

Yup, we can do that as well

If you assign me I can do that.

sboy99 commented 1 year ago

If you assign me I can do It is assigned to you. Add a comment in #139

priyankarpal commented 1 year ago

@ArslanYM are you working on this issue?

ArslanYM commented 1 year ago

No im not

suzy-g38 commented 1 year ago

No im not

Hey if you don't want to work on this issue, @priyankarpal can I work on this one?

priyankarpal commented 1 year ago

No im not

Hey if you don't want to work on this issue, @priyankarpal can I work on this one?

You can work on it 🤝 @suzy-g38

suzy-g38 commented 1 year ago

I want to add some images as a reference but the images are not loading properly. I followed the drag-and-drop method using Shift to add the image links....but it's not working somehow. I am sharing the screenshots:

Editor Screen

image

Website Page

image

And also I want to add that I have added the images in a folder 'how-to-add-svg-icon' inside the /images/getting-started.

priyankarpal commented 1 year ago

use this trick & just paste the link.

https://user-images.githubusercontent.com/88102392/231248176-bf66004a-7824-437d-93d5-70df6a2b22c0.mp4

suzy-g38 commented 1 year ago

use this trick & just paste the link.

Cool man loved it.