pbcweb / mobile-bookmark-bubble

Automatically exported from code.google.com/p/mobile-bookmark-bubble
Apache License 2.0
0 stars 0 forks source link

should not display if in-app web viewer #16

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Load the webapp within a web view inside some non-Safari app.
2. The bubble appears, pointing at a non-existent Bookmark button.

What is the expected output? What do you see instead?

The bubble should not appear if the user isn't viewing the web app with Mobile 
Safari. It does appear.

What version of the product are you using? On what operating system?

The version listed as revision b3d04bb1ed17 in the change log. Downloaded on 
July 25, 2011. Hosting on Mac OS X 10.6.7, and viewing on iOS 4.3.5. 

Please provide any additional information below.

The regex that tests for Safari actually only tests for a web view on an 
iPhone, iPod, or iPad. It should actually test for safari, since web views 
within non-Safari apps leave that out of the user agent (which is otherwise the 
same). 

SOLUTION: Change the regular expression for detecting Mobile Safari, 
MOBILE_SAFARI_USERAGENT_REGEX_, to the following:
/(iPhone|iPod|iPad).*Safari/

That works properly, at least when tested with a web app running within 
FileMaker Go versus the same web app running with Mobile Safari. Both return 
true when only testing for /iPhone|iPod|iPad/ 

Original issue reported on code.google.com by danielas...@gmail.com on 26 Jul 2011 at 9:15