search

pbearne / wp-author-avatars

copy of the SVN at http://wordpress.org/extend/plugins/author-avatars/ wordpress plugin
4 stars 7 forks source link

Syntax Error in ShowAvatarShortcode.class.php #1

Closed BFTrick closed 11 years ago

BFTrick commented 11 years ago

I was all ready to make some modifications to the shortcode but when I attempted to activate the github plugin I got an error:

Screen Shot 2013-03-18 at 1 15 03 PM

I tried to make sense of the issue and it looks like there are tons of missing parenthesis.

Also, not sure if you use git for version control but if you're actively developing a code base then a useful tip is to use a development branch. Then, people who want to submit a patch can do so based on the production code which you can merge into your development branch.

pbearne commented 11 years ago

Hi

All I did to push a git hub copy was to copy the head to a new folder and pushed to git hub

I looked at trying to link the SVN and GIT but could get my head round it

So plan to pull the git back and copy the changes back over to the SVN

PS I am away for the the next 2 weeks so I may not be able to pull the patches until I get back

I am looking forward to looking at the changes from you

Please add notes and credits for work to the readme

Paul

Paul Bearne Canadian Mobile: +1 647 780 7594 Home Office: +1 416 792 8894 _E-mail: _paul@bearne.com* pbearne@gmail.com* @pbearne http://twitter.com/pbearne or +pbearnehttps://plus.google.com/u/0/100456877588970933323

On Mon, Mar 18, 2013 at 3:56 PM, Patrick Rauland notifications@github.comwrote:

I was all ready to make some modifications to the shortcode but when I attempted to activate the github plugin I got an error:

[image: Screen Shot 2013-03-18 at 1 15 03 PM]https://f.cloud.github.com/assets/1065372/272480/ea4d9d2a-9004-11e2-9192-c84905e7fa5c.png

I tried to make sense of the issue and it looks like there are tons of missing parenthesis.

Also, not sure if you use git for version control but if you're actively developing a code base then a useful tip is to use a development branch. Then, people who want to submit a patch can do so based on the production code which you can merge into your development branch.

— Reply to this email directly or view it on GitHubhttps://github.com/pbearne/wp-author-avatars/issues/1 .

BFTrick commented 11 years ago

You can certainly have the git repo mirror the svn repo (which is what WordPress does) but then when someone creates a patch you'll have to copy it into the svn repo and their patch will just be a part of the update which is a shame.

You can also make git your primary repo and then automatically push it to the WordPress SVN repo. There's a couple blog posts about it; I wrote one myself. This way when people contribute it is all left intact.

pbearne commented 11 years ago

I am happy to make git the master so I am playing with your script

pbearne commented 11 years ago

fixed

A load of } where missing

Strange

pbearne commented 11 years ago

I have added your code to the athoravtar shortcode as well so pull A new copy to do a last test

BFTrick commented 11 years ago

Hi Paul,

I just updated your code so hopefully all of the weird bracket issues are taken care of.