search

pbek / QOwnNotes

QOwnNotes is a plain-text file notepad and todo-list manager with Markdown support and Nextcloud / ownCloud integration.
https://www.qownnotes.org/
GNU General Public License v2.0
4.72k stars 413 forks source link

[I] Closing parenthesis is part of hyperlink #2510

Open wolframroesler opened 2 years ago

wolframroesler commented 2 years ago

Expected behaviour

When a markdown document contains a hyperlink in parentheses (like this: http://example.com), the closing parenthesis and anything after it should not be part of the hyperlink.

Actual behaviour

The closing parenthesis and a following comma or period are part of the hyperlink (for example, http://example.com).

Steps to reproduce

Put a hyperlink into parentheses (for example, http://example.com).

Relevant log output in the Log panel

Expand ``` [10:33:42] [status] Stored 1 note(s) to disk ```

Information about the application, settings and environment

Expand QOwnNotes Debug Information =========================== ## General Info **Current Date**: `Do. Apr. 7 10:33:48 2022` **Version**: `22.4.0` **Build date**: `Apr 4 2022` **Build number**: `960` **Platform**: `linux` **Operating System**: `Ubuntu 20.04.4 LTS` **Build architecture**: `x86_64` **Current architecture**: `x86_64` **Release**: `Launchpad PPA` **Qt Version (build)**: `5.12.8` **Qt Version (runtime)**: `5.12.8` **Portable mode**: `no` **Settings path / key**: `/home/wolfram/.config/PBE/QOwnNotes.conf` **Application database path**: `/home/wolfram/.local/share/PBE/QOwnNotes/QOwnNotes.sqlite` **Application arguments**: `QOwnNotes` **Qt Debug**: `0` **Locale (system)**: `en_GB` **Locale (interface)**: *empty* **Primary screen resolution**: `2560x1440` **Icon theme**: *empty* **Notes in current note folder**: `3` **Calendar items**: `0` **Enabled scripts**: `0` ## Server Info **serverUrl**: *empty* **appIsValid**: `no` **notesPathExists**: *empty* **connectionErrorMessage**: *empty* ## Spellchecking **Enabled**: `false` **Selected language**: `auto` **Language codes**: `de_AT, de_AT_frami, de_CH, de_CH_frami, de_DE, de_DE_frami, en_AU, en_CA, en_GB, en_US, en_ZA` **Language names**: `Österreichisches Deutsch (Österreich), Österreichisches Deutsch (Österreich), Schweizer Hochdeutsch (Schweiz), Schweizer Hochdeutsch (Schweiz), Deutsch (Deutschland), Deutsch (Deutschland), Australian English (Australia), Canadian English (Canada), British English (United Kingdom), American English (United States), English (South Africa)` **Application dictionaries path**: `/home/wolfram/.local/share/PBE/QOwnNotes/dicts` ## Note folders **currentNoteFolderId**: `2` ### Note folder `default` **id**: `2` **isCurrent**: `yes` **activeTagId**: `0` **localPath**: `/home/wolfram/SynologyDrive/Notes` **remotePath**: `Notes` **cloudConnectionId**: `1` **isShowSubfolders**: `no` **isUseGit**: `no` **allowDifferentNoteFileName**: `no` **activeNoteSubFolder name**: *empty* **database file**: `/home/wolfram/SynologyDrive/Notes/notes.sqlite` ## Cloud connections ### Cloud connection `Default` **id**: `1` **isCurrent**: `yes` **serverUrl**: *empty* **username**: *empty* **accountId**: *empty* ## Enabled scripts ## Settings **ActiveNoteHistoryItem** (NoteHistoryItem): `` **Debug/fakeOldVersionNumber** (bool): `false` **Debug/fileLogging** (bool): `false` **Editor/ColorSchemes** (QString): `EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2` **Editor/CurrentSchemaKey** (QString): `EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2` **Editor/autoBracketClosing** (bool): `false` **Editor/autoBracketRemoval** (bool): `false` **Editor/disableCursorBlinking** (bool): `false` **Editor/editorWidthInDFMOnly** (bool): `true` **Editor/highlightCurrentLine** (bool): `false` **Editor/indentSize** (int): `4` **Editor/removeTrailingSpaces** (bool): `false` **Editor/showLineNumbers** (bool): `false` **Editor/useTabIndent** (bool): `false` **Editor/vimMode** (bool): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_-1** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_0** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1000** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1001** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1002** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1003** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1004** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1005** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_1006** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_12** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_13** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_14** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_15** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_16** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_17** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_18** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_19** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_2** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_21** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_22** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_23** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_25** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_28** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_3** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_4** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_7** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColorEnabled_8** (QString): `false` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_-1** (QColor): `#201f1f` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_0** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1000** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1001** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1002** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1003** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1004** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_1005** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_12** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_13** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_14** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_15** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_16** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_17** (QColor): `#ebebf0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_18** (QColor): `#f5f9d8` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_19** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_2** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_21** (QColor): `#444444` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_22** (QColor): `#3e3e44` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_23** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_25** (QColor): `#3e3c36` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_28** (QColor): `#3e3c36` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_3** (QColor): `#e4ffe4` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_4** (QColor): `#333333` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_7** (QColor): `#9eb6ff` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/BackgroundColor_8** (QColor): `#dbf9e5` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_12** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_13** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_14** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_15** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_16** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_17** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Bold_8** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1000** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1001** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1002** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1003** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1004** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1005** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_1006** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_23** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontEnabled_4** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_12** (QString): `200` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_13** (QString): `160` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_14** (QString): `130` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_16** (QString): `90` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_17** (QString): `90` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/FontSizeAdaption_18** (QString): `90` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1000** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1001** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1002** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1003** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1004** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1005** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_1006** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_23** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Font_4** (QFont): `DejaVu Sans Mono,12,-1,5,50,0,0,0,0,0` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_-1** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_0** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_10** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1000** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1001** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1002** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1003** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1004** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1005** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_1006** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_11** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_12** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_13** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_14** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_15** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_16** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_17** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_18** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_19** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_2** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_20** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_21** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_22** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_23** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_24** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_26** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_29** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_3** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_30** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_4** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_5** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_6** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_7** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_8** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColorEnabled_9** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_-1** (QColor): `#eeffdd` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_0** (QColor): `#729fcf` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1** (QColor): `#fc7e00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_10** (QColor): `#ffff00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1000** (QColor): `#c4a000` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1001** (QColor): `#8ae234` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1002** (QColor): `#888a85` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1003** (QColor): `#c4a000` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1004** (QColor): `#e69f66` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1005** (QColor): `#8ae234` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_1006** (QColor): `#a6e22e` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_11** (QColor): `#686868` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_12** (QColor): `#fce94f` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_13** (QColor): `#fce94f` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_14** (QColor): `#edd400` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_15** (QColor): `#c4a000` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_16** (QColor): `#c4a000` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_17** (QColor): `#c4a000` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_18** (QColor): `#babdb6` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_19** (QColor): `#00aa00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_2** (QColor): `#fc7e00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_20** (QColor): `#e1e1e1` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_21** (QColor): `#d5d5d5` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_22** (QColor): `#f6ffe9` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_23** (QColor): `#59bf40` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_24** (QColor): `#505050` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_26** (QColor): `#ff5500` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_29** (QColor): `#ff5a5a` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_3** (QColor): `#00bf00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_30** (QColor): `#c3ff82` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_4** (QColor): `#70bf40` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_5** (QColor): `#e1e1e1` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_6** (QColor): `#e1e1e1` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_7** (QColor): `#eeffdd` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_8** (QColor): `#eeffdd` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/ForegroundColor_9** (QColor): `#ffff00` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Italic_1002** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Italic_18** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Italic_7** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Name** (QString): `Wolfram dark` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Underline_0** (QString): `true` **EditorColorSchema-6a764b18-589f-4691-bd77-2da9a754a8c2/Underline_26** (QString): `true` **FileDialog/LastPath** (QString): `/home/roesler/Public/dotfiles/QOwnNotes` **FileDialog/LastPath-SchemaImport** (QString): `/home/roesler/Public/dotfiles/QOwnNotes` **IssueAssistantDialog/geometry** (QByteArray): `` **LastUpdateCheck** (QDateTime): `2022-04-07T09:34:47.822` **LogWidget/criticalLog** (bool): `true` **LogWidget/debugLog** (bool): `true` **LogWidget/fatalLog** (bool): `true` **LogWidget/infoLog** (bool): `true` **LogWidget/scriptingLog** (bool): `true` **LogWidget/statusLog** (bool): `true` **LogWidget/warningLog** (bool): `true` **MainWindow/geometry** (QByteArray): `` **MainWindow/mainToolBar.iconSize** (int): `24` **MainWindow/menuBarGeometry** (QByteArray): `` **MainWindow/noteTextEdit.code.font** (QString): `DejaVu Sans,10,-1,5,50,0,0,0,0,0` **MainWindow/noteTextEdit.font** (QString): `DejaVu Sans,10,-1,5,50,0,0,0,0,0` **MainWindow/noteTextView.code.font** (QString): `DejaVu Sans,12,-1,5,50,0,0,0,0,0` **MainWindow/noteTextView.font** (QString): `DejaVu Sans,12,-1,5,50,0,0,0,0,0` **MainWindow/noteTextView.ignoreCodeFontSize** (bool): `true` **MainWindow/noteTextView.rtl** (bool): `false` **MainWindow/noteTextView.underline** (bool): `true` **MainWindow/noteTextView.useEditorStyles** (bool): `true` **MainWindow/noteTextView.useInternalExportStyling** (bool): `true` **MessageBoxOverride/readonly-mode-allow** (QString): `16384` **NoteFolder-2/NoteTabNameList** (QStringList): `Tuxedo InfinityBook` **NoteFolder-2/NoteTabStickinessList** (QStringList): *empty* **NoteFolder-2/NoteTabSubFolderPathDataList** (QStringList): *empty* **NoteFolder-2/allowDifferentNoteFileName** (bool): `false` **NoteHistory-2** (QVariantList): `` **NoteHistoryCurrentIndex-2** (int): `2` **PiwikClientId** (QString): `` **ScriptRepositoryDialog/mainSplitterState** (QByteArray): `` **SearchEngineId** (int): `2` **SettingsDialog/geometry** (QByteArray): `` **SettingsDialog/mainSplitterState** (QByteArray): `` **ShowSystemTray** (bool): `false` **StartHidden** (bool): `false` **WelcomeDialog/geometry** (QByteArray): `` **acceptAllExternalModifications** (bool): `true` **allowNoteEditing** (bool): `true` **allowOnlyOneAppInstance** (bool): `true` **appMetrics/disableAppHeartbeat** (bool): `false` **appMetrics/disableTracking** (bool): `false` **appMetrics/notificationShown** (QString): `true` **automaticNoteFolderDatabaseClosing** (bool): `false` **checkSpelling** (QString): `false` **closeTodoListAfterSave** (bool): `false` **cryptoKey** (QString): `` **currentNoteFolderId** (int): `2` **currentWorkspace** (QString): `initial` **cursorWidth** (int): `1` **darkMode** (bool): `true` **darkModeColors** (bool): `true` **darkModeIconTheme** (bool): `true` **darkModeTrayIcon** (bool): `true` **defaultNoteFileExtension** (QString): `md` **demoNotesCreated** (QString): `true` **disableAutomaticUpdateDialog** (bool): `true` **disableSavedSearchesAutoCompletion** (bool): `false` **dockWasInitializedOnce** (QString): `true` **enableNoteTree** (bool): `false` **enableSocketServer** (bool): `false` **enableWebAppSupport** (bool): `false` **externalEditorPath** (QString): *empty* **fullyHighlightedBlockquotes** (bool): `true` **gitCommitInterval** (int): `30` **gitExecutablePath** (QString): *empty* **gitLogCommand** (QString): *empty* **guiFirstRunInit** (bool): `true` **ignoreAllExternalModifications** (bool): `false` **ignoreAllExternalNoteFolderChanges** (bool): `false` **ignoreNoteSubFolders** (QString): `^\.` **imageScaleDown** (bool): `false` **imageScaleDownMaximumHeight** (int): `1024` **imageScaleDownMaximumWidth** (int): `1024` **initialLayoutIdentifier** (QString): `minimal` **insertTimeFormat** (QString): *empty* **interfaceFontSize** (int): `11` **interfaceLanguage** (QString): *empty* **internalIconTheme** (bool): `false` **itemHeight** (int): `19` **legacyLinking** (bool): `false` **localTrash/autoCleanupDays** (int): `30` **localTrash/autoCleanupEnabled** (bool): `true` **localTrash/supportEnabled** (bool): `true` **markdownHighlightingEnabled** (bool): `true` **navigationPanelAutoSelect** (bool): `true` **navigationPanelHideSearch** (bool): `false` **networking/ignoreSSLErrors** (bool): `true` **networking/proxyType** (int): `2` **newNoteAskHeadline** (bool): `false` **noteEditIsCentralWidget** (bool): `true` **noteFileExtensionList** (QStringList): `md, txt` **noteListPreview** (bool): `false` **noteSaveIntervalTime** (int): `3` **noteSubfoldersPanelDisplayAsFullTree** (bool): `true` **noteSubfoldersPanelHideSearch** (bool): `false` **noteSubfoldersPanelOrder** (int): `0` **noteSubfoldersPanelShowFullPath** (bool): `false` **noteSubfoldersPanelShowNotesRecursively** (bool): `false` **noteSubfoldersPanelShowRootFolderName** (bool): `true` **noteSubfoldersPanelSort** (int): `0` **notesPanelOrder** (int): `0` **notesPanelSort** (int): `0` **notesPath** (QString): `/home/wolfram/SynologyDrive/Notes` **notifyAllExternalModifications** (bool): `false` **overrideInterfaceFontSize** (bool): `false` **ownCloud/supportEnabled** (bool): `false` **ownCloud/todoCalendarBackend** (int): `3` **ownCloud/todoCalendarCalDAVPassword** (QString): `` **ownCloud/todoCalendarCalDAVServerUrl** (QString): *empty* **ownCloud/todoCalendarCalDAVUsername** (QString): *empty* **ownCloud/todoCalendarCloudConnectionId** (int): `1` **ownCloud/todoCalendarDisplayNameList** (QStringList): *empty* **ownCloud/todoCalendarEnabledList** (QStringList): *empty* **ownCloud/todoCalendarEnabledUrlList** (QStringList): *empty* **ownCloud/todoCalendarUrlList** (QStringList): *empty* **restoreCursorPosition** (bool): `true` **restoreLastNoteAtStartup** (bool): `true` **restoreNoteTabs** (bool): `true` **savedSearches/noteFolder-2** (QStringList): `Note 2022-04-06T11.34.47` **showMatches** (bool): `true` **showMenuBar** (bool): `true` **showStatusBar** (bool): `false` **spellCheckLanguage** (QString): `auto` **systemIconTheme** (bool): `false` **taggingShowNotesRecursively** (bool): `false` **tagsPanelHideNoteCount** (bool): `false` **tagsPanelHideSearch** (bool): `false` **tagsPanelOrder** (int): `0` **tagsPanelSort** (int): `0` **todoCalendarSupport** (bool): `false` **toolbar/1/items** (QStringList): `action_New_note, action_Find_note, action_Remove_note, action_Open_note_in_external_editor, actionShow_local_trash, actionAllow_note_editing, , action_Back_in_note_history, action_Forward_in_note_history, , action_Find_text_in_note, actionReplace_in_current_note, , actionShow_versions, actionShow_trash, actionShare_note, , actionShow_Todo_List` **toolbar/1/name** (QString): `mainToolBar` **toolbar/1/title** (QString): `main toolbar` **toolbar/2/items** (QStringList): `actionFormat_text_bold, actionFormat_text_italic, actionStrike_out_text, actionInsert_code_block, actionInsert_block_quote` **toolbar/2/name** (QString): `formattingToolbar` **toolbar/2/title** (QString): `formatting toolbar` **toolbar/3/items** (QStringList): `actionInsert_text_link, actionInsert_image, actionInsert_current_time` **toolbar/3/name** (QString): `insertingToolbar` **toolbar/3/title** (QString): `inserting toolbar` **toolbar/4/items** (QStringList): `action_Encrypt_note, actionEdit_encrypted_note, actionDecrypt_note` **toolbar/4/name** (QString): `encryptionToolbar` **toolbar/4/title** (QString): `encryption toolbar` **toolbar/5/items** (QStringList): `actionWorkspaceComboBox, actionStore_as_new_workspace, actionRemove_current_workspace, actionRename_current_workspace, actionSwitch_to_previous_workspace, actionUnlock_panels, , actionToggle_distraction_free_mode, action_Increase_note_text_size, action_Decrease_note_text_size, action_Reset_note_text_size` **toolbar/5/name** (QString): `windowToolbar` **toolbar/5/title** (QString): `window toolbar` **toolbar/6/items** (QStringList): `action_Quit` **toolbar/6/name** (QString): `quitToolbar` **toolbar/6/title** (QString): `quit toolbar` **toolbar/size** (int): `6` **useNoteFolderButtons** (bool): `false` **useUNIXNewline** (bool): `false` **webAppClientService/serverUrl** (QString): `wss://app.qownnotes.org` **webAppClientService/token** (QString): `` **webSocketServerService/bookmarksNoteName** (QString): `Bookmarks` **webSocketServerService/bookmarksTag** (QString): `bookmarks` **webSocketServerService/commandSnippetsNoteName** (QString): `Commands` **webSocketServerService/commandSnippetsTag** (QString): `commands` **webSocketServerService/port** (int): `22222` **workspace-initial/name** (QString): `Minimal` **workspace-initial/noteSubFolderDockWidgetVisible** (QString): `true` **workspace-initial/windowState** (QByteArray): `` **workspaces** (QString): `initial` ## System environment **LANGUAGE**: `en_GB:en` **USER**: `wolfram` **LC_TIME**: `de_DE.UTF-8` **XDG_SESSION_TYPE**: `x11` **SSH_AGENT_PID**: `4535` **SHLVL**: `0` **HOME**: `/home/wolfram` **DESKTOP_SESSION**: `budgie-desktop` **GIO_LAUNCHED_DESKTOP_FILE**: `/usr/share/applications/PBE.QOwnNotes.desktop` **GTK_MODULES**: `appmenu-gtk-module:gail:atk-bridge` **XDG_SEAT_PATH**: `/org/freedesktop/DisplayManager/Seat0` **LC_MONETARY**: `de_DE.UTF-8` **DBUS_SESSION_BUS_ADDRESS**: `unix:path=/run/user/1000/bus` **GIO_LAUNCHED_DESKTOP_FILE_PID**: `15787` **UBUNTU_MENUPROXY**: `1` **MANDATORY_PATH**: `/usr/share/gconf/budgie-desktop.mandatory.path` **QT_QPA_PLATFORMTHEME**: `qt5ct` **LOGNAME**: `wolfram` **XDG_SESSION_CLASS**: `user` **DEFAULTS_PATH**: `/usr/share/gconf/budgie-desktop.default.path` **GNOME_DESKTOP_SESSION_ID**: `this-is-deprecated` **PATH**: `/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin` **GDM_LANG**: `en_GB` **PAPERSIZE**: `a4` **SESSION_MANAGER**: `local/tux610:@/tmp/.ICE-unix/4470,unix/tux610:/tmp/.ICE-unix/4470` **XDG_SESSION_PATH**: `/org/freedesktop/DisplayManager/Session1` **LC_ADDRESS**: `de_DE.UTF-8` **XDG_RUNTIME_DIR**: `/run/user/1000` **XDG_MENU_PREFIX**: `gnome-` **DISPLAY**: `:0` **LANG**: `en_GB.UTF-8` **XDG_CURRENT_DESKTOP**: `Budgie:GNOME` **LC_TELEPHONE**: `de_DE.UTF-8` **XDG_SESSION_DESKTOP**: `budgie-desktop` **XAUTHORITY**: `/home/wolfram/.Xauthority` **XMODIFIERS**: `@im=ibus` **XDG_GREETER_DATA_DIR**: `/var/lib/lightdm-data/wolfram` **SSH_AUTH_SOCK**: `/run/user/1000/keyring/ssh` **SHELL**: `/bin/bash` **LC_NAME**: `de_DE.UTF-8` **QT_ACCESSIBILITY**: `1` **GDMSESSION**: `budgie-desktop` **LC_MEASUREMENT**: `de_DE.UTF-8` **GPG_AGENT_INFO**: `/run/user/1000/gnupg/S.gpg-agent:0:1` **LC_IDENTIFICATION**: `de_DE.UTF-8` **QT_IM_MODULE**: `ibus` **PWD**: `/home/wolfram` **XDG_CONFIG_DIRS**: `/etc/xdg/xdg-budgie-desktop:/etc/xdg` **XDG_DATA_DIRS**: `/usr/share/budgie-desktop:/usr/local/share:/usr/share:/var/lib/snapd/desktop` **LC_NUMERIC**: `de_DE.UTF-8` **LC_PAPER**: `de_DE.UTF-8`
pbek commented 2 years ago

You are talking about the highlighting, not the actual link (when you ctrl+click on it), right?

Yes, I guess it would be better to exclude it in the highlighting. @Waqar144, your thoughts?

wolframroesler commented 2 years ago

Both highlighting and link target are affected. For example, if I put the following into a note:

(https://en.wikipedia.org/wiki/QOwnNotes):

then QOwnNotes displays the closing parenthesis and colon in blue, and ctrl-clicking the hyperlink tries to open https://en.wikipedia.org/wiki/QOwnNotes):.

Btw, GitHub is getting it right (https://en.wikipedia.org/wiki/QOwnNotes): The closing parenthesis and colon aren't part of the link.

pbek commented 2 years ago

I really don't know what the "rule" is for links that are not marked as links in Markdown... The safest way is always to use <https://en.wikipedia.org/wiki/QOwnNotes>:), you don't have any issues with that.

wolframroesler commented 2 years ago

Hard to tell how to do it right. Parentheses are definitely legal in URLs (e. g., https://en.wikipedia.org/wiki/Notes_(album)), and note that GitHub identifies the first ) as part of the URL but not the second, like it's checking whether the matching ( is part of the URL or not. Let's try it out:

How about braces?

And brackets?

Oh. How about angle brackets:

Maybe https://www.ietf.org/rfc/rfc1738.txt has something to say about it? Or perhaps it's because in natural language URLs in parentheses happen more frequently than in braces or brackets.

Anyway, would be great if QOwnNotes could do the same. Wrapping URLs in < > as a workaround doesn't seem very elegant to me since URLs usually work fine without them.

For the record, here's how QOwnNotes currently renders the above:

Screenshot from 2022-04-07 15-54-50

Waqar144 commented 2 years ago

Known issue and I think already noted in one of the highlighting issues I created.

Question is whether it's worth it to fix this properly and handle all edge cases or not. Maybe there is regex out there that can handle it completely, don't know. Also there are about 6 or 7 different types of url formats that need to be handled, all of varying characteristics.

pbek commented 2 years ago

Sounds like a lot of hassle... 😅