search

pberkes / big_O

Python module to estimate big-O time complexity from execution time
BSD 3-Clause "New" or "Revised" License
324 stars 50 forks source link

GitHub actions workflow for sending a package to pypi on release #50

Closed jpphilips closed 2 years ago

jpphilips commented 2 years ago

Setup File Structure ~Setup pypi project on https://pypi.org/project/big-o-pbeekes/0.0.1/~ Setup workflow

pberkes commented 2 years ago

Hi @jpphilips , thank you for the PR.

There are several issues with the PR that would need to be fixed before merging 1) A PyPi package for BigO already exists https://pypi.org/project/big-O/ 2) The current version is 0.10.2, as defined in the setup.py file 3) My name is misspelled, and the email addresses are fake 4) We can discuss about authorship, but it's either everyone who ever participated, or just me as the original author and main contributor 5) The project URLs are fake 6) The PR changes the permissions of all files, why is that? 6) I would like to have a solution based on the existing setup.py, rather than adding a toml file and having to maintain both

pberkes commented 2 years ago
  1. The PR also moved all the tests somewhere else
jpphilips commented 2 years ago

Thanks for the feedback

  1. Noted. sorry about that
  2. fixed
  3. fixed
  4. Set you as only author
  5. fixed
  6. I don't know about this. Pls check the recent commit to see if it has been resolved
  7. I will delete the toml file yes?
  8. fixed
pberkes commented 2 years ago

Thank you for the changes. The version of the github action you are using is also very old. I'll make some changes and re-submit with you as author

pberkes commented 2 years ago

@jpphilips I committed a branch called pypi-workflow containing the changes you made that are relevant for this task, with you as author. Could you please open a new PR with that branch? Normally I would do it, but I fear you wouldn't get the Hacktoberfest credits

jpphilips commented 2 years ago

Alright. Thank you but I'm unable to see the branch you created

pberkes commented 2 years ago

how about now?

jpphilips commented 2 years ago

Yes but

Pull request creation failed. Validation failed: You can't perform that action at this time.

pberkes commented 2 years ago

you would need to pull the branch in your fork, then do a PR from there

pberkes commented 2 years ago

Closing in favor of #51