Fix for iOS crash when calling hide() after the indicator has already…

pbernasconi / cordova-progressIndicator

Native Progress-Indicator for Cordova

pbernasconi.github.io/cordova-progressIndicator/

Apache License 2.0

90 stars 61 forks source link

Fix for iOS crash when calling hide() after the indicator has already… #21

Open Justin-Credible opened 9 years ago

Justin-Credible commented 9 years ago

… been hidden

By nilling out the progressIndicator instance variable in the hide method, multiple calls to hide() after a progress indicator has already hidden will prevent this plugin from crashing on iOS.

micky2be commented 9 years ago

Want

daviddahl commented 9 years ago

Why does this PR affect 1721 files? I would also like this issue resolved but this PR seems broken to me

Justin-Credible commented 9 years ago

My original pull request was never merged, and I forgot it was still open. I then also removed the entire demo directory because it contained paths that were too long for Windows.