search

pbeshai / react-url-query

A library for managing state through query parameters in the URL in React
https://pbeshai.github.io/react-url-query
MIT License
194 stars 38 forks source link

PropTypes Deprication #57

Closed carpiediem closed 5 years ago

carpiediem commented 6 years ago

Do you want to request a feature or report a bug? bug

What is the current behavior? Warning from ESLint: React.PropTypes is deprecated since React 15.5.0, use the npm module prop-types instead

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar. Compile demo code with babel

What is the expected behavior? No deprecation warning

Which versions of react-url-query, and which browser and OS are affected by this issue? Did this work in previous versions of react-url-query? current

leonelgalan commented 5 years ago

Everywhere in the code it says: import PropTypes from 'prop-types';, the only places where PropTypes was read from React was in:

import React, { Component, PropTypes } from 'react';
import React, { PureComponent, PropTypes } from 'react';

Because the issue mentions "demo code" it probably refers to the code in the documents. I can submit a PR, are the docs coming from the docs folder in master? My guess is master, the gh-pages branch? BTW, the gh-pages branch appears to be very old and outdated.

carpiediem commented 5 years ago

Because the issue mentions "demo code" it probably refers to the code in the documents.

This is correct. Sorry for being unclear.