search

pbiecek / archivist

A set of tools for datasets and plots archiving
http://pbiecek.github.io/archivist/
74 stars 9 forks source link

bug in addHooksToPrint #288

Closed pbiecek closed 8 years ago

pbiecek commented 8 years ago

Something is broken after recent changes

This line is not working: addHooksToPrint(class="ggplot", repoDir = "arepo", repo = "Eseje", user = "pbiecek", subdir = "arepo")

Error in parse(text = fun) : <text>:2:69: unexpected ')'
1: function(x, ..., artifactName = deparse(substitute(x))) {
2:                   hash <- saveToRepo(x, artifactName = artifactName))
MarcinKosinski commented 8 years ago

So what was the solution? Or this is still a bug?

pbiecek commented 8 years ago

It was fixed here: https://github.com/pbiecek/archivist/commit/b1183e0ed31571969ee2cfe2d5fd223cc7bf0aaa

MarcinKosinski commented 8 years ago

Does this mean we need to update this on CRAN? I've made such a stupid mistake :P

pbiecek commented 8 years ago

The fix is already in v 2.1

2016-08-03 0:44 GMT+02:00 Marcin Kosiński notifications@github.com:

Does this mean we need to update this on CRAN? I've made such a stupid mistake :P

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pbiecek/archivist/issues/288#issuecomment-237071459, or mute the thread https://github.com/notifications/unsubscribe-auth/AEaPvqPXBD1_sOdaznmvxr2an_MljPp8ks5qb8hegaJpZM4JWR-S .

pozdrawiam serdecznie, Przemysław Biecek

MarcinKosinski commented 8 years ago

Great, thanks