search

pbiggar / phc

A compiler for PHP
132 stars 37 forks source link

unneeded LoC #124

Open pbiggar opened 9 years ago

pbiggar commented 9 years ago 
Hi,
in the dataflow branch, file optimize/Prune_symbol_table.cpp
in line 130 the assignement is unnecessary because you pass in the vars
already as argument to the Analysis constructor. Just having one way of
getting vars ought to be enough i think.

Original issue reported on code.google.com by c.r1@gmx.de on 2009-10-17 13:40:57

pbiggar commented 9 years ago 
Seems right. Have you tested the change?

Original issue reported on code.google.com by paul.biggar on 2009-10-17 20:12:56

pbiggar commented 9 years ago 
I gotta say I fear this. My personal alias analysis is not very good, but this change
triggers a warning. It would need to be tested before doing this...

Original issue reported on code.google.com by paul.biggar on 2010-09-22 05:02:04