search

pbix / HA-solark-PV

Home Assistant integration for the SolArk PV Inverter
Apache License 2.0
36 stars 9 forks source link

Add AC and DC Heatsink Temperature sensors #48

Closed poldim closed 3 months ago

poldim commented 4 months ago

I'd like to monitor my unit's heatsink temps as sensors.

Per my docs, these are registers 90 + 91. Adding them as disabled. image

I'm not sure if anything else needs to be changed to pull in the sensors other than the two files I've modified.

I'm not a programmer and have very little knowledge of how all this magic works, so take it with a grain of salt!

poldim commented 3 months ago

@pbix - Anything I can do to help this along?

pbix commented 3 months ago

Sorry I completely missed your pull request. Looks pretty straight forward but must ask you the most important question. Did you test this change on your own box?

poldim commented 3 months ago

Sorry I completely missed your pull request. Looks pretty straight forward but must ask you the most important question. Did you test this change on your own box?

I'm not familiar enough with GH to figure out how to install a PR version of an integration. But I did create manual Modbus sensors that worked. If you have any guidance on how to do that, I don't mind testing it.

pbix commented 3 months ago

You can just copy the files you propose to the custom_components/solark_modbus and restart HA and watch the logs.

If it loads and works then the risk is low.

poldim commented 3 months ago

I just tested it and needed to adjust the skip bytes. But now it works for me. I'm not sure if I need to do anything differently in this PR or if it will automatically use the 6 that is in https://github.com/poldim/HA-solark-PV/blob/main/custom_components/solark/hub.py#L184