search

pbkhrv / rtl_433-hass-addons

Collection of Home Assistant add-ons that use rtl_433
237 stars 108 forks source link

set the correct URL for the next autodiscovery image #164

Closed benklop closed 1 year ago

benklop commented 1 year ago

Summary

The path to the 'next' version of the rtl_433_mqtt_autodiscovery add-on is incorrect, and so when trying to install home assistant actually installs a copy of the main / release version instead. The path should contain 'next-' from what I can tell based on the container names.

Alternatives Considered

I've created my own copy of the repo to work on another feature, and discovered this in the meantime. I can use my own copy of the image there only by making this change.

Testing Steps

  1. forked the repo
  2. changed all the paths / actions / repo names to point to my copies of these things
  3. disabled building of the non-next versions of the images
  4. Built the images
  5. was not able to install (home assistant gave an error about the image not being available)
  6. Applied this fix
  7. was able to install
catduckgnaf commented 1 year ago

@benklop I have dont have as much interest in developing the add-on and I want to focus on the integration. I have done some work previously, and am hosting a repo mostly dedicated to just the script. Lets chat over discord, (and if anyone else is interested. Per RTL_433 the goal of the project is to produce raw output, things like Intergrations are merely suggestions to build on. Let me know if we can connect, https://discord.gg/FFdJMPeP

deviantintegral commented 1 year ago

Wow, nice digging! I double checked as well against the Actions logs and this should be good. Thank you!

deviantintegral commented 1 year ago

I think for this to actually be fixed we'll have to roll a release, or at least merge to the main branch.

deviantintegral commented 1 year ago

Looks like this is going to fail until https://github.com/pbkhrv/rtl_433-hass-addons/pull/165 is fixed.

deviantintegral commented 1 year ago

Thanks!