search

pbl-nl / appl-docchat

Chat with your own documents pressure cooker
https://github.com/pbl-nl
MIT License
17 stars 4 forks source link

hybrid search implementation #142

Closed StefanTroost closed 3 months ago

StefanTroost commented 3 months ago

Hi @ChrisCleaner, I'd like your review on this PR. It implements "hybrid search", a searching strategy in the vector database that combines semantic search with keyword search, see also: https://python.langchain.com/v0.1/docs/modules/data_connection/retrievers/ensemble/

ChrisCleaner commented 3 months ago

Should we write a separate Unit Test for the hybrid search? Or do you reckon it is not necessary right now?

StefanTroost commented 3 months ago

Hi @ChrisCleaner, yes good idea. I had not thought of that yet...

ChrisCleaner commented 3 months ago

@StefanTroost Should I merge it without the Unit Test alerady or do I wait? (I could also write a unit test for it if neessary)

StefanTroost commented 3 months ago

Well adding a unit test is a valuable addition. If you have time to add one, that would be great!

From: ChrisCleaner @.> Sent: Tuesday, July 23, 2024 1:52 PM To: pbl-nl/appl-docchat @.> Cc: Troost, Stefan @.>; Mention @.> Subject: Re: [pbl-nl/appl-docchat] hybrid search implementation (PR #142)

@StefanTroosthttps://github.com/StefanTroost Should I merge it without the Unit Test alerady or do I wait? (I could also write a unit test for it if neessary)

— Reply to this email directly, view it on GitHubhttps://github.com/pbl-nl/appl-docchat/pull/142#issuecomment-2245024629, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXEHWFUOUELRAR5XWI5N7DZNY7UZAVCNFSM6AAAAABLJXF2FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGAZDINRSHE. You are receiving this because you were mentioned.Message ID: @.**@.>>