search

pblittle / docker-logstash

Docker image for Logstash 1.4
https://hub.docker.com/r/pblittle/docker-logstash
MIT License
237 stars 90 forks source link

Corrects env variable names for external es service #101

Closed awyrough closed 9 years ago

awyrough commented 9 years ago

Current master branch allows no way to run an external ES service through setting of environment variables in docker run command.

There is a mismatch in the names. Makefile uses "ES_SERVICE_HOST/PORT" while the rest of the code base is expecting / using "ES_HOST/PORT". Additionally, the README reflects the "ES_HOST/PORT" naming.

awyrough commented 9 years ago

@pblittle Thanks for getting back to me. It was open, but I'm closing because I realized what I did was incorrect. Apologies for the over eager PR!

I might be totally missing something, but perhaps it is just a question of the external ES config example in the README? docker run -d \ -e ES_HOST=<your_es_service_host> \ -e ES_PORT=<your_es_service_port> \ -p 9292:9292 \ pblittle/docker-logstash why are we setting ES_HOST and ES_PORT when everything else looks directly for ES_SERVICE_HOST/PORT?

thx for the help

pblittle commented 9 years ago

@awyrough, you might be on to something here. It looks like using ES_SERVICE_HOST and ES_SERVICE_PORT was an oversight on my part. The environment variables in your PR, ES_HOST and ES_PORT, are correct.

If you don't mind, please change your base branch to a feature branch off of develop. I have the contribution steps documented in the README file. That will give me a chance to test the change before the automated build on Docker Hub starts.

Thanks. I appreciate you taking the time to track this issue down.

awyrough commented 9 years ago

@pblittle apologies for not reading the contribution steps. I submitted this via a separate PR to start fresh. Hope that was okay.

https://github.com/pblittle/docker-logstash/pull/104