search

pblittle / docker-logstash

Docker image for Logstash 1.4
https://hub.docker.com/r/pblittle/docker-logstash
MIT License
236 stars 90 forks source link

Don't download LOGSTASH_CONFIG_FILE if one is provided #15

Closed hamiltont closed 10 years ago

hamiltont commented 10 years ago

Could be done by changing this:

wget $LOGSTASH_CONFIG_URL -O $LOGSTASH_CONFIG_FILE
if [ ! -f "${LOGSTASH_CONFIG_FILE}" ]; then
    wget $LOGSTASH_CONFIG_URL -O $LOGSTASH_CONFIG_FILE
fi
hamiltont commented 10 years ago

Recent docker versions support -v /my/logstash.conf:/opt/logstash.conf, so this would allow the user to specify their own configuration without having to host then download it

pblittle commented 10 years ago

@hamiltont, looks good to me. Please send me a PR and I'll get it in the next build.

For what it's worth, I'm working on a much more robust config system. I'll try to push the feature branch up in the next week or so to make sure everyone is cool with the direction I'm taking.

pblittle commented 10 years ago

Thanks again @hamiltont. Closing issue.