search

pblittle / docker-logstash

Docker image for Logstash 1.4
https://hub.docker.com/r/pblittle/docker-logstash
MIT License
236 stars 90 forks source link

Use Debian instaead of Ubuntu as base #22

Closed ianks closed 10 years ago

ianks commented 10 years ago

This will reduce some of the bloat from Ubuntu, yet give us the apt-get goodness. From my initial tests the image size is smaller, and things seems to be functioning as expected.

Size of Ubuntu Image: 1.36gb Size of Debian Image: 673mb

summera commented 10 years ago

:+1:

pblittle commented 10 years ago

@ianks, I think this is a great idea to discus. I have explored a few different options so far, from Debian Wheezy to CoreOs.

My primary reservation for not pulling the trigger yet is the lack of a solid test suite. I would feel much more comfortable making low level changes like this with solid tests in place first.

I have a decent embedded elasticsearch test now, but I don't have a linked container test that I'm happy with.

Also, if the base OS is changed, I might move back to using an updated version of my docker-base image. That will slim this Dockerfile down and cache the base image for other projects.

@ianks, @summera, what are your thoughts?

ianks commented 10 years ago

From what I can tell from the code, this image is not reliant on any Ubuntu specific features. It is booting elasticsearch, wget and using some typical unix commands. None of which have Ubuntu OS features as a dependency. The fact that init is never being called means you are essentially using Ubuntu for its package manager.

pblittle commented 10 years ago

@ianks, you're correct about the lack of reliance on Ubuntu OS features. Thanks for pointing that out and the contribution.

ianks commented 10 years ago

Sure, this image has been useful :)

ianks commented 10 years ago

@pblittle What are your thoughts on merging this?

pblittle commented 10 years ago

@ianks, I was traveling this week and am finally getting caught up tonight. I'll pull it in as soon as the DEBIAN_FRONTEND discussion in #23 is sorted out. I would like to bundle both features in the rel-0.8.0 release.