pblxptr / ecoNET-300-Home-Assistant-Integration

ecoNET300 Home Assistant is a custom integration for ecoNET300 devices.
16 stars 6 forks source link

Help with the project #17

Open hajkenek opened 1 year ago

hajkenek commented 1 year ago

Hi, if you want some help with the app, give me your contact and then we can talk more in dm :D

anowicki8422 commented 1 year ago

I have no problem, but I miss measuring the buffer temperature.

śr., 24 maj 2023, 18:40 użytkownik Jakub @.***> napisał:

Hi, if you want some help with the app, give me your contact and then we can talk more in dm :D

— Reply to this email directly, view it on GitHub https://github.com/pblxptr/ecoNET-300-Home-Assistant-Integration/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2UBO5WJO35XKU3ZFUHD6TXHY2XXANCNFSM6AAAAAAYNUVXHM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jontofront commented 1 year ago

Hi, if you want some help with the app, give me your contact and then we can talk more in dm :D

Hi, Do you mean for developing?

hajkenek commented 1 year ago

Yep, I mean developing (maybe more testing, because I own kostrzewa boiler with econet module). I had serveral approaches to decode some json data in the winter and found some useful entities.

pblxptr commented 1 year ago

Hi @hajkenek, In general, if you have an idea about what could be added - entities and so on, you can create an issue and describe it - like e.g. @jontofront did some time ago. If you're fine with programming you can go one step further and create a PR with the implementation. I would prefer to have the whole communication regarding possible features here, because e.g. if you have an idea about the entity you would like to add, and you describe it in the appropriate issue, somebody else will have a chance to take it and implement it when I'm busy - and that's unfortunately something likely to happen as I've been currently working on something completely different. Adding entities is currently quite easy, it only requires adding an appropriate entry describing some keys provided by API. Btw currently on the branch 'dev-mixers-and-numbers' there is an implementation with mixer devices. It's limited (on purpose) but should provide basic functionality that would allow us to test if it works properly. If you want and have time, you can have a look at this and check if it works correctly :)

@anowicki8422 I will have a look at this.

anowicki8422 commented 1 year ago

Read the temperature buffer measurement reading (upper and lower). After these lines, the program does not download data Do you have an idea for a name: key and name?

EconetSensorEntityDescription(
    key="lower_buffer_temp",
    name="lower_buffer_temp",
    icon="mdi:thermometer",
    native_unit_of_measurement=TEMP_CELSIUS,
    state_class=SensorStateClass.MEASUREMENT,
    device_class=SensorDeviceClass.TEMPERATURE,
    process_val=lambda x: round(x, 2)
),
anowicki8422 commented 1 year ago

I managed in the sensor.py file, add: EconetSensorEntityDescription( key="tempLowerBuffer", name="Lower buffer temperature", icon="mdi:thermometer", native_unit_of_measurement=TEMP_CELSIUS, state_class=SensorStateClass.MEASUREMENT, device_class=SensorDeviceClass.TEMPERATURE, process_val=lambda x: round(x, 2) ), EconetSensorEntityDescription( key="tempUpperBuffer", name="Upper buffer temperature", icon="mdi:thermometer", native_unit_of_measurement=TEMP_CELSIUS, state_class=SensorStateClass.MEASUREMENT, device_class=SensorDeviceClass.TEMPERATURE, process_val=lambda x: round(x, 2) )

pblxptr commented 1 year ago

Sorry guys but so far I have no way to test this changes as my device got broken and I've been waiting for a week for a technician who is supposed to fix it. @anowicki8422 May I ask you to create a separate issue with this change? It will be easier to keep the PR history cleaner. Also if you're willing you can create a PR :)

jontofront commented 1 year ago

@anowicki8422 can you open a new ticket when you try to implement something with a short description? After that I also can test f-nality or sensors

jontofront commented 10 months ago

I have no problem, but I miss measuring the buffer temperature. śr., 24 maj 2023, 18:40 użytkownik Jakub @.> napisał: Hi, if you want some help with the app, give me your contact and then we can talk more in dm :D — Reply to this email directly, view it on GitHub <#17>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT2UBO5WJO35XKU3ZFUHD6TXHY2XXANCNFSM6AAAAAAYNUVXHM . You are receiving this because you are subscribed to this thread.Message ID: @.>

Can you explain more deeply which parameter? this? image

jontofront commented 10 months ago

tempLowerBuffer

Sorry but in my case there is no this key tempLowerBuffer econet/regParams?