codepathreview
commented
7 years ago :+1: nice work. A few notes after checking out the code:
-
Nice to see you used a drawable and/or styles to customize the view
-
Nice to see you played around with styling the sliding tab strip
- Remember to add an indeterminate progress indicator during background tasks
-
Correctly and appropriately used OnClickListeners on the user's profile image to navigate to their profile view
-
Good to see you properly communicated the user to the user timeline fragment from the profile activity.
-
Glad to see you properly hooked up each of the different timelines to infinitely paginate.
-
For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.
-
Consider adding local persistence of tweets by using DBFlow in the
TweetandUser. See the persistence guide and this other guide for more details.
/cc @coderschoolreview
1- Whenever sending a network request, be sure to handle the failure case as outlined in our http://guides.codepath.com/android/Sending-and-Managing-Network-Requests#sending-an-api-request 2- Did you properly persist tweets to disk and then retrieve them from disk and display them immediately (or at least on network failure?). See http://guides.codepath.com/android/Persisting-Data-to-the-Device and http://guides.codepath.com/android/DBFlow-Guide for more details. 3-Learning how to http://guides.codepath.com/android/Using-Intents-to-Create-Flows#receiving-implicit-intents from other apps helps facilitate default links and images to be shared through your Twitter client.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.