Include tests for failure and coercion

pboesu / rucrdtw

R Bindings for the UCR Suite for fast time series subsequence search

Other

15 stars 4 forks source link

Include tests for failure and coercion #2

Closed noamross closed 7 years ago

noamross commented 7 years ago

Tests are included and all tests pass, and coverage is high. I note that where coverage is missing, it is largely because there are not tests that coercion and error handling occur properly (example). I suggest adding tests to cover these cases, e.g. using expect_error().

This issue is part of JOSS review https://github.com/openjournals/joss-reviews/issues/100

pboesu commented 7 years ago

added tests for missing input files, wrong input types and dimensions, and columnwise data input for vm methods (Commits up to 8d00a9c1083bb1652353c4267a3269684680057c)

noamross commented 7 years ago

Looks good!