search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Empty conda package for windows #112

Closed adriendelsalle closed 3 years ago

adriendelsalle commented 4 years ago

Hi!

I tried to use your lib with conda package for Windows which seems to be empty. I opened an issue on the conda-forge feedstock but no one had a look since.

Could you please tell me if you also maintain the conda feedstock? Any hint to make it work?

Thanks!

pboettch commented 4 years ago

I don't know conda, but maybe @linus-gates and #110 can help?

pboettch commented 3 years ago

With the tag 2.1.0 made this week, did it improve the situation on conda's side?

linus-gates commented 3 years ago

No, what's wrong with the conda package for windows is that there isn't any bld.bat file which describes how to compile it to windows (there is build.sh for linux)

pboettch commented 3 years ago

What can we do in the repository?

adriendelsalle commented 3 years ago

Hi @pboettch @linus-gates I confirmed the windows package is still empty. As mentioned by @linus-gates and my issue on the feedstock, the windows recipe is missing.

To fix that we need to ask the current feedstock maintainer(s) to become maintainer and push a fix, or maybe only make a PR on that. I'm not used to that. @fcollonval, you already made this, could you please describe what are the options here? Thanks!

pboettch commented 3 years ago

I happily accept a pull-request.

adriendelsalle commented 3 years ago

This is on the conda forge feedstock repo that the modification has to be made 😅

pboettch commented 3 years ago

Then, I'm closing this one for now.

adriendelsalle commented 3 years ago

@pboettch FYI I finally finished that PR this morning (sorry I left it in progress for a while!). https://github.com/conda-forge/json_schema_validator-feedstock/pull/4

It adds recipes for both win and osx.