search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
470 stars 135 forks source link

Feat: Add uuid support #167

Closed Leon0402 closed 2 years ago

Leon0402 commented 2 years ago

Support for the uuid format of the json schema standard. Also added some more documentation to the readme.

Leon0402 commented 2 years ago

Also added some tests

Leon0402 commented 2 years ago

I wrote the test myself, because I thought that's what you did as well.

UUID is actually tested by the project you mentioned: https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/master/tests/draft-future/optional/format/uuid.json. But not in draft 7.

So how do we proceed?

pboettch commented 2 years ago

Great, OK, everything is clear now.

Let's take (and copy) the test from 2020-12 to this project (this is how I did for the others tests, except I took the draft-7 ones) and integrate your changes.

pboettch commented 2 years ago

I integrated the changes related to the UUID-format-string-checker. Everything else was removed. Especially the changes to the CMakeLists.txt files. There is another PR open which handles this.

Leon0402 commented 2 years ago

Oh no, the cmake changes were not supposed to be pushed anyway, I'm sorry. I just added / commented out some stuff so testing would be easy for me. It seems I pushed them yesterday as well.

Thanks for fixing!