search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Update CI and fix warnings #214

Closed res0nance closed 1 year ago

res0nance commented 1 year ago

Hi @pboettch, PTAL.

This updates CI to run on main and uses the latest nlohmann-json to test. This also adds the to_string() call to remove warnings.

The current tag is also very old so could we get an updated tag?

pboettch commented 1 year ago

If we test with 3.11 should we also limit the version use in the code?

res0nance commented 1 year ago

If we test with 3.11 should we also limit the version use in the code?

I don't think we have to these changes should be backwards compatible since the use of to_string() already appears in this library and in nlohmann/json, It claims that the addition of to_string() has been there since 2.0.0

I think what we should do is perhaps add another CI job that tests on the oldest supported version which is 3.8.0.

pboettch commented 1 year ago

That sounds like a good idea.

When you say the tag is very, what you mean is you'd like to have a new(er) release?

res0nance commented 1 year ago

That sounds like a good idea.

When you say the tag is very, what you mean is you'd like to have a new(er) release?

Yeah a new release would be good considering that the last one was 2 years ago.

pboettch commented 1 year ago

Time goes by very fast.