search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Add uri format check #227

Closed sebasfalcone closed 1 year ago

sebasfalcone commented 1 year ago

This PR aims to close the following issue

Change log

pboettch commented 1 year ago

LGTM; but please get rid of the white-space changes in the CMakeLists.txt of the test-suite.

sebasfalcone commented 1 year ago

@pboettch I've run the clang-format to the CMakeLists.txt file, let me know if it's okay. Thanks for the help and quick responses!

pboettch commented 1 year ago

No, don't run clang-format on the cmake-lists-file. It's only for C/C++ files.

Just revert all your changes of the CMakeLists.txt-file and only commit your actual change.

sebasfalcone commented 1 year ago

What a mess I've made. Sorry for the waterfall of notification :)

sebasfalcone commented 1 year ago

Hello @pboettch, how's that going? Is this PR on any road-map for the project?

pboettch commented 1 year ago

I'm overloaded, I need to find some time to take a closer look to the open PRs.