search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Use Ragel generated RFC-5321/RFC-6531 Mailbox address parser #235

Closed gene-hightower closed 1 year ago

gene-hightower commented 1 year ago

Generated code copied from: https://github.com/gene-hightower/smtp-address-parser

fixes: #152

pboettch commented 1 year ago

Could you try to fix the errors the CI reported?

gene-hightower commented 1 year ago

Could you try to fix the errors the CI reported?

Oh, right. I've used C++17 without even really thinking about it.

gene-hightower commented 1 year ago

So, I'm proposing to require C++17, as it's the default version of C++ for GCC and Clang now if you don't specify something else, it's been the standard for over five years, and it's almost fully supported by the major compilers.

pboettch commented 1 year ago

Sorry for the late response.

I want to stick to nlohmann::json's requirements and this is C++11. Is it possible for you to change your code to make it work with only C++11 - features?

gene-hightower commented 1 year ago

Is it possible for you to change your code to make it work with only C++11 - features?

Sure.

pboettch commented 1 year ago

I rebased your changes and integrated them in a squashed commit.