search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Compatibility with latest nlohmann::json? #236

Closed Sil3ntStorm closed 1 year ago

Sil3ntStorm commented 1 year ago

There seems to have been a few changes to nlohmann::json, which causes this library to use deprecated functions, causing issues during compilation.

pboettch commented 1 year ago

With latest, do you mean 3.11.2? Or the develop-branch?

Sil3ntStorm commented 1 year ago

latest release tag yes.

pboettch commented 1 year ago

I just build the main-branch of this project against json 3.11.2 and there was no warning or error.

Please post your compile log.

Sil3ntStorm commented 1 year ago

json-scheme.hpp:64 json-scheme.hpp:84 Warning C4996 'nlohmann::json_abi_v3_11_2::json_pointer::operator std::basic_string<char,std::char_traits,std::allocator>': Since 3.11.0; use to_string()

pboettch commented 1 year ago

The main-branch of this project is up to date regarding this requirement.

Sil3ntStorm commented 1 year ago

Would you mind creating a new release? Package managers (such as vcpkg or conan) usually work with release tags only and do not track branches.

pboettch commented 1 year ago

OK, I'm waiting for #235, but yeah it's time