pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Local include for smtp-address-validator.hpp #240

Closed garethsb closed 1 year ago

garethsb commented 1 year ago

This makes string-format-check.cpp consistent with smtp-address-validator.cpp. This means that the nlohmann directory itself doesn't have to be in the system search path. (The directory in which the nlohmann directory is contained is much more likely to be, so e.g. #include <nlohmann/json-schema.hpp> is fine.)

pboettch commented 1 year ago

Yes, I saw that after committing. Do you think this can generate build problems somewhere?

garethsb commented 1 year ago

Did for me after copying files into same source tree where I was using version 2.1.0 previously. Easily fixed 🙂

pboettch commented 1 year ago

OK, then I will wait for some time before doing a 2.2.1 .