search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
466 stars 134 forks source link

Apply pre-commit fixes #260

Closed LecrisUT closed 1 year ago

LecrisUT commented 1 year ago

Depends-on: #259

See my fork for current CI status until workflow is approved.

LecrisUT commented 1 year ago

Consider merging them in order to keep some reviewable history/git blame

LecrisUT commented 1 year ago

Do you want to have the CI pass for this one?

pboettch commented 1 year ago

Should it pass?

LecrisUT commented 1 year ago

Not in this form. The other does though

pboettch commented 1 year ago

Hmm, the other PR I merged earlier should have been one that makes the CI go green. I actually thought it would.

So then, the next one has to. Which one is it?

LecrisUT commented 1 year ago

So the first PR didn't because it didn't contain the pre-commit fixes. This one doesn't because it doesn't find nlohmann/json package and intel builder fails. These could be temporarily fixed. Next one is indeed fixed completely. Can check the status on my fork.

pboettch commented 1 year ago

Just rebase and push force here, it will run the/your checks.

LecrisUT commented 1 year ago

This one is already incorporated in the other one. Sorry i didn't mark it appropriately. It should have been merged before. Well it's ok right now.