search

pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
464 stars 133 forks source link

Could you add some BUILD.bazel files to support bazel build? #269

Open HiaWinter opened 11 months ago

HiaWinter commented 11 months ago

My project using bazel to build and I want to import your project, if you think it's ok to add some BUILD.bazel files in your project, I can raise a PR to support it, thanks.

LecrisUT commented 11 months ago

As long as the main build is going through cmake it should be fine. Can discuss more about the design in the PR since it is faster to weed out the details with an example.

pboettch commented 11 months ago

Oh, I think we should just change it back for people using the library without CMake after building. There are some I guess. Could you take care of it, @LecrisUT - as you are the who broke it :-P .

LecrisUT commented 11 months ago

Sure, I'll make a hotfix in a minute. Let's open an issue to plan some renamings. Target names will become unmanagable otherwise.

LecrisUT commented 11 months ago

@pboettch Sorrry, we got the wrong issue here. This is the bazel issue not the soname one

pboettch commented 11 months ago

Not we. It's only me. Doing 5 things at the same time....

LecrisUT commented 11 months ago

Also to blame because I marked it with Fixes in the PR :grin:

pboettch commented 5 months ago

HiaWinter, are you able to suggest a PR for integrating Bazel-support?