Open LecrisUT opened 11 months ago
The naming convention is getting out of hand. [..]
rofl
But you're right. KISS.
This could go along with namespace refactoring.
Proposed nlohmann_json_schema_validator
-> Json_Validator
<PROJECT_NAME_UPPERCASE>_<Option_Name>
<Project_Name>_<Target_Name>
(internally) and <Project_Name>::<Target_Name>
(externally)<Project_Name>
(This might be enforced in cmake upstream in the future)<Project_Name>Config.cmake
(Enforced, use find_package(NAMES)
for compatibility)<Project_Name>Targets.cmake
(invisible to the user, does not really matter)<Project_Name>_VERSION
Proposed nlohmann_json_schema_validator
-> json-validator.so
Proposed:
nlohmann_json_schema_validator
-> Json_Validator_library
+ Json_Validator::Json_Validator
(convention breaking for the main target)CMake project name
notes.I don't know about bazel/conan side if there is anything to be discussed there.
Tldr
Things that will be renamed:
Details
The naming convention is getting out of hand and it should be simplified. For now this issue is gathering the targets to be renamed. Will update the details down below.