pboettch / json-schema-validator

JSON schema validator for JSON for Modern C++
Other
464 stars 133 forks source link

Improve Conanfile for consumers of the package #292

Closed JacobCrabill closed 5 months ago

JacobCrabill commented 8 months ago

The export_sources field of the conanfile was incorrect, preventing downstream packages from consuming this package.

I also took the liberty of making some changes to the Conanfile to make the build more "standard" and easier to work with (allowing the use of a simple Makefile to easily build & test the package).

JacobCrabill commented 7 months ago

@pboettch anything I can do to speed this along?

pboettch commented 7 months ago

Hmm, I have to admit that adding a GNU Makefile is not something I'd consider. Is this a common way for Conan-enabled projects?

pboettch commented 7 months ago

Especially that you Makefile does not really have dependencies, so a simple shell-script would do it the same way.

JacobCrabill commented 7 months ago

@pboettch a BASH script could do the same, but in my day job we've standardized on Makefiles as a somewhat simpler and intuitive method of implementing build scripts. This way, when you clone a repo following this convention, all you have to do is type make and you're done. With a BASH script, you first have to find the script, figure out if it needs any arguments, or search for the custom commands it exports, etc.

JacobCrabill commented 7 months ago

I can remove the Makefile from the PR if you'd like; the Conanfile changes are what's important. The Makefile is just a quality-of-life improvement with no downsides.

pboettch commented 7 months ago

Yes, please remove the Makefile and add instruction (and links) to the README-file for conan-users (if necessary).

pboettch commented 5 months ago

PR Merged (with rebase) manually.