search

pbogre / jetlog

Personal flight tracker and viewer
https://github.com/pbogre/jetlog
GNU General Public License v2.0
199 stars 9 forks source link

Build docker container for ARM processors #29

Closed benjaminjonard closed 3 months ago

benjaminjonard commented 3 months ago

Hello, first of all thanks for this software, I really like it.

Would it be possible to add compatibility with ARM processors ? It would be nice to be able to run jetlog on a raspberry pi for example

pbogre commented 3 months ago

I'm glad you're enjoying the project.

This shouldn't be a complicated addition, I just need to add linux/arm64 to the --platforms option when building the docker image. I'll test this soon

Docker docs

I wonder if this will affect the size of the downloaded image?

benjaminjonard commented 3 months ago

Thanks 👍

It will create 2 different images for a each tag, so it won't impact the original image size. (when using docker run or docker compose up, Docker will guess which image to use based on the machine architecture)

pbogre commented 3 months ago

After building the image with the following command:

docker buildx build -t pbogre/jetlog:experimental -f Dockerfile . --platform=linux/amd64,linux/arm64

The image with :experimental tag should be available for both platforms. I will change this to :latest when there has been enough testing.

benjaminjonard commented 3 months ago

I tested the experimental image on a Raspberry Pi and another arm device and it works great. Thanks !