Allowing to return or skip invalid dates

pbogut / recurring_events

Elixir library for dealing with recurring events

MIT License

26 stars 8 forks source link

Allowing to return or skip invalid dates #20

Closed kelvinst closed 3 years ago

kelvinst commented 3 years ago

Closes #19

On monthly repetitions, invalid dates like 2020-11-31 can be generated.

The way the lib was working until now was that it would fallback to the last day of the month in that case, but as the RFC for RRULE has a different take on that, I think it is a nice to have, at least as an option.

So I added the :invalid option to the rules, allowing the devs either get the invalid dates by setting it to :return or skipping them by setting to :skip. Defaults to :fallback

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 80

22 of 22 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 78:	0.0%
Covered Lines:	289
Relevant Lines:	289

💛 - Coveralls

pbogut commented 3 years ago

Thank you for your contribution.

kelvinst commented 3 years ago

Hey @pbogut, can you mark the PR with the label hacktoberfest-accepted so it gets elegible for the t-shirt for me? 😂