chore: remove rails 5 deprecation

pboling / flag_shih_tzu

Bit fields for ActiveRecord

http://railsbling.com/flag_shih_tzu

MIT License

496 stars 64 forks source link

chore: remove rails 5 deprecation #57

Closed shanebonham closed 7 years ago

shanebonham commented 7 years ago

Fixes #54

coveralls commented 7 years ago

Coverage decreased (-8.9%) to 37.966% when pulling 04fd0a374e6f813665c62d5a88ab774fb4a45791 on shanebonham:tables-data-sources into c28a287270cba310b57f98b26ac79d33c2366516 on pboling:master.

coveralls commented 7 years ago

Coverage decreased (-8.9%) to 37.966% when pulling 04fd0a374e6f813665c62d5a88ab774fb4a45791 on shanebonham:tables-data-sources into c28a287270cba310b57f98b26ac79d33c2366516 on pboling:master.

moonzez commented 7 years ago

Hello @shanebonham , are there any plans to merge this change into master or provide another fix? We are about to upgrade our app to rails5, would be great to have this deprecation fixed

shanebonham commented 7 years ago

@moonzez see https://github.com/pboling/flag_shih_tzu/pull/57#discussion_r88795090

I believe data_sources only became available in Rails 5. I haven't had time yet to look into altering my commit to continue supporting older versions of Rails.

pboling commented 7 years ago

@moonzez @shanebonham we have to bite the bullet at some point and throw off the old versions of rails. We can start with a clean 1.0.0 line of gems that only support Rails 5, and leave the old 0.x line for the old versions of Rails. Then there is a LOT of cleanup we can do, and switches we can remove. I will:

[ ] tweak the readme to reflect the version support for each branch going forward
[ ] redo this change with a switch to continue supporting old versions of Rails on the 0.x line.
[ ] create a rails_lt_5 branch that will keep the old Rails support intact
[ ] release 0.3.16 from rails_lt_5
[ ] update master to remove the switch, and many other switches

xinranxiao commented 7 years ago

This can be closed (fixed by https://github.com/pboling/flag_shih_tzu/pull/59)