pboling / flag_shih_tzu

Bit fields for ActiveRecord
http://railsbling.com/flag_shih_tzu
MIT License
496 stars 64 forks source link

Fix update statements on sqlite, and quote all table/column names #65

Closed jdelStrother closed 7 years ago

jdelStrother commented 7 years ago

sqlite doesn't support multi-table updates, and throws a syntax error if we try to specify the table name on the left hand side of the update (eg UPDATE foo SET foo.flags = ...).

Fixing that was the original impetus for this branch, but I ended up using ActiveRecord's quoting methods, so as a bonus we now have correctly-quoted table & column names.

Hopefully this will fix travis....

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 5e254b3148a16f09308b74edbc5bfa237a1e264e on jdelStrother:sqlite-tablename-fix into on pboling:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 5e254b3148a16f09308b74edbc5bfa237a1e264e on jdelStrother:sqlite-tablename-fix into on pboling:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling c92add7a97398959971d2c3657c94cf66dc941a7 on jdelStrother:sqlite-tablename-fix into on pboling:master.

pboling commented 7 years ago

Thank you so much!!!