pboling / flag_shih_tzu

Bit fields for ActiveRecord
http://railsbling.com/flag_shih_tzu
MIT License
496 stars 64 forks source link

"Drop" Rails 2.3 support #66

Closed deivid-rodriguez closed 7 years ago

deivid-rodriguez commented 7 years ago

I was very surprised that this gem supported Rails 2.3. After checking Travis, it seems like it does not, so this is just cleaning up, not actually dropping anything since it's already broken.

You should drop support for EOL'd Rails and Ruby versions though (Rails 3.0, 3.1, 3.2, 4.0, 4.1, MRI 1.9.3, 2.0, 2.1).

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 53.16% when pulling 1a183e050f890464b4fdbdf78d3e8875958f87b1 on deivid-rodriguez:cleanup_version_support into d7b75b09fafb6b178e5301b738a774af4a12e8aa on pboling:master.

pboling commented 7 years ago

It was supporting Rails 2.3 and Ruby 1.9.3 because the only project I used this gem for many years was a legacy Rails 2.3 app. 😆 Like the actual Rails 2.3 LTS version: https://github.com/makandra/rails

It is my sense that this gem, being 10 years old, has a large base of legacy users, but I haven't really gathered any data on that topic.

The only reason the build began failing for Ruby 1.9.3 was some gems that weren't locked began requiring Ruby >= 2.0 (like tins). I'll see if I can easily fix that.

I can't drop support for a Ruby without bumping a major version, so it would mean a 1.0 release (finally!) which I am hoping to get to, but I wanted to do a rewrite of the internals before then.

deivid-rodriguez commented 7 years ago

You not only need Rails 2.3 users for a reason to keep support. You need Rails 2.3 users who want to upgrade this gem but stay on Rails 2.3. That's incredibly weird.

Also, you're in version 0.x, you should feel free to do what you want with your version support if it simplifies maintenance. You don't need 1.0.0. If you don't think this gem is ready to call it 1.0.0 without a rewrite, that's very reasonable. But that doesn't mean you can't drop support for anything. My two cents.

pboling commented 7 years ago

I suppose we could do minor releases dropping support. I will consider dropping Rails 2.3 for the 0.4 release.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling ab62265f9386fb9bb45d772bc1562555841d922b on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling ab62265f9386fb9bb45d772bc1562555841d922b on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

deivid-rodriguez commented 7 years ago

Ok, I rebased this PR for you in case it's useful for the future!

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.6%) to 48.052% when pulling 79d891f14ef6288af0a0d13e9fd4add3d7a8083c on deivid-rodriguez:cleanup_version_support into a43a0ee5f5cb40503f55e74102c0dc96e4f7452b on pboling:master.

pboling commented 7 years ago

excellent, thanks. I will merge this once I move master to target the 0.4 release, which should be in the next week or so.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 48.052% when pulling 75d623d80e2a2ac289b860b67f9a24f66b6ee647 on deivid-rodriguez:cleanup_version_support into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 48.052% when pulling 75d623d80e2a2ac289b860b67f9a24f66b6ee647 on deivid-rodriguez:cleanup_version_support into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

pboling commented 7 years ago

I do still want to do this! I just haven't had much time. I'll reopen when I can get to it.