search

pboling / flag_shih_tzu

Bit fields for ActiveRecord
http://railsbling.com/flag_shih_tzu
MIT License
496 stars 64 forks source link

fixed Rails5.1 DEPRECATION WARNING #69

Closed shiro16 closed 7 years ago

shiro16 commented 7 years ago

AR 5.1 after save use #changes is DEPRECATION WARNING Thus create new method #saved_change_to_{flag_name}? https://github.com/rails/rails/blob/1c275d812f35f53f93cd96184a4f319983766cc5/activerecord/lib/active_record/attribute_methods/dirty.rb#L23-L24

DEPRECATION WARNING: The behavior of `changes` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_changes` instead.
coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 47.634% when pulling aee4051b91d13ffdf4c4ddb19523ffce64e6f9ae on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+4.5%) to 52.296% when pulling 6089c33d0ba0d1825e9118b1b4bec89e833bf5a3 on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+3.6%) to 51.407% when pulling cf011e2bca5e859e6156da9e36bca6b69f108396 on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 6f553e0dc3233559db776e9a7d17530d435b9d8a on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 47.975% when pulling 33ddc67c8da650692a1ba49ff4134f927820d1a8 on shiro16:fixed-rails5.1-deplication-warning into c7a927f4bbc04f99e1cf771050ca4bc71f469144 on pboling:master.

pboling commented 7 years ago

Thanks @shiro16 !