search

pboling / flag_shih_tzu

Bit fields for ActiveRecord
http://railsbling.com/flag_shih_tzu
MIT License
496 stars 64 forks source link

When #selected_flags= passed with nil it clears flag bits. #75

Closed xpol closed 6 years ago

xpol commented 6 years ago

This would make flag_shih_tzu works with Rails which would convert empty array to nil.

See:

https://github.com/rails/rails/issues/13766 https://github.com/rails/rails/pull/13188

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 50.833% when pulling 11c44781bc475856540e680348e8a34ea820279a on xpol:clear_selectd_flags_when_assign_nil into 0623a85936dc854fbf6b4ea2c731264668012cb1 on pboling:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.2%) to 54.104% when pulling ec5afa6a8b1c5333c5b43092c8c567e88fbc1b05 on xpol:clear_selectd_flags_when_assign_nil into b07b5a72111240cd5cb56a96722e80debf691fd0 on pboling:master.

pboling commented 6 years ago

This looks great! Just need to figure out what is wrong with the test suite.

pboling commented 6 years ago

Oops, accidentally closed.

xpol commented 6 years ago

Sorry tired my best to fix the deps issue. But I'm not able to fix them all.

pboling commented 6 years ago

I'll work on it soon πŸ‘

pboling commented 6 years ago

@xpol I have fixed the build issues! Please rebase πŸ‘

xpol commented 6 years ago

Rebased

pboling commented 6 years ago

@xpol released 0.3.22 with this change. πŸ‘

xpol commented 6 years ago

πŸ‘ Peter Boling notifications@github.com于2018εΉ΄9月19ζ—₯ ε‘¨δΈ‰δΈŠεˆ5:44ε†™ι“οΌš

@xpol https://github.com/xpol released 0.3.22 with this change. πŸ‘

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pboling/flag_shih_tzu/pull/75#issuecomment-422567121, or mute the thread https://github.com/notifications/unsubscribe-auth/AABPGLR4czJ102rJb-jmJA7UAmfv5gWgks5ucWlZgaJpZM4Tu0WB .