search

pboling / rack-insight

Debugging toolbar for Rack applications implemented as middleware
http://railsbling.com/retired_projects/rack-insight/
MIT License
151 stars 22 forks source link

Call function to toggle bookmarket. #8

Closed oggy closed 9 years ago

oggy commented 12 years ago

So I tried your app mentioned in pull request 6, as well as a fresh, minimal Rails 3.2.8 app which I can provide if necessary, and in both cases the bookmarklet (at /__insight__/bookmarklet.html) does not give me the password prompt nor toggle the state of the toolbar. Tried with Chrome 23.0.1262.0 dev and Firefox 13.0.1.

In brynary's rack-bug, I can see that this function is called at the end of the bookmarklet js. The corresponding file in rack-insight does not have this call, and I did not see where this call could have been moved to. So here I move it to the bookmarklet link itself, which fixes it for me.

pboling commented 12 years ago

The top left hand pixel of the screen is green and when hovered over becomes a larger link. When clicked this link launches the popup asking for the password. It has been a few years since I've used Rack::Bug, but this was forked from logical-insight which was a complete rewrite of Rack::Bug, and they don't work exactly the same way. I think the experience you are expecting is not how it works.

I have installed it on a bare 3.2.8 app, and a mature 3.2.6 app and haven't had any trouble with it. I will check out this pull request locally before merging.

oggy commented 12 years ago

You're right - I was expecting that executing the bookmarklet toggled the state like rack-bug. I never used logical-insight.

Your call on how you want it to behave of course. If you leave it as is, I think we can remove the bookmarklet, as all it does is add a script to the page which is already there.

pboling commented 9 years ago

Closing with deference to https://github.com/pboling/rack-insight/issues/40