search

pbosler / lpm

Lagrangian Particle Methods
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

Dfs solver #119

Closed michaelchiwere1 closed 2 months ago

michaelchiwere1 commented 4 months ago

Corrections to the dfs solver to fix multithreading problem.

pbosler commented 4 months ago

I'm still getting lots of ASAN errors (see below) when I try to build, even with the -fsanitize=address line deleted from src/CMakeLists.txt. Have you found a fix, perhaps with the build commands for FFTW3/FINUFFT?

/opt/rh/gcc-toolset-11/root/usr/bin/ld: /home/pabosle/lpm-dfs/build-default/_deps/finufft-src/contrib/legendre_rule_fast.cpp:387: undefined reference to `__asan_report_load8'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: /home/pabosle/lpm-dfs/build-default/_deps/finufft-src/contrib/legendre_rule_fast.cpp:387: undefined reference to `__asan_report_store8'
michaelchiwere1 commented 4 months ago

I have added an RK4 time-stepping method in the RK2 class. The proposed plan is to have one time-stepping class with multiple time-step methods.

pbosler commented 2 months ago

I'm going to close this PR without merging. We'll do another PR when we've figured out dependency issues such as #112.