search

pboyer / antlr4

ANTLR (ANother Tool for Language Recognition) is a powerful parser generator for reading, processing, executing, or translating structured text or binary files.
http://antlr.org
Other
26 stars 1 forks source link

Sign CLA #86

Closed sridharxp closed 7 years ago

pboyer commented 7 years ago

Hi @sridharxp!

I never asked you to sign the CLA because, strictly speaking, you did not commit any code.

However, you definitely helped out with the code with your issues. Some of which included actual code that led to a fix.

Here's what I'd suggest:

Open a PR against antlr/antlr4 with:

  1. One commit with your name added to the CLA. That's it - one commit. This PR has a bunch of weird merges that will mess up the history.
  2. In your PR, describe this situation. e.g. "I didn't commit any code directly, but I helped with the following issues where I provided some code that led to a fix."
  3. Along with that, include all of the issues you made against this repo. Particularly the ones which led to a fix.

cc @parrt

pboyer commented 7 years ago

BTW @sridharxp Let me know if you need help with the mechanics of git. You can usually find me on gitter.im/pboyer/antlr4.