search

pbreault / adb-idea

A plugin for Android Studio and Intellij IDEA that speeds up your day to day android development.
Apache License 2.0
2.1k stars 256 forks source link

Plugin Broken with AS 3.6 Canary 12 #113

Closed eygraber closed 4 years ago

eygraber commented 4 years ago

I've been getting multiple reports of the following Exception when using the plugin (i.e. taking an action from the dialog):

java.lang.NoSuchMethodError: org.jetbrains.android.facet.AndroidFacet.getManifest()Lorg/jetbrains/android/dom/manifest/Manifest;
    at com.developerphil.adbidea.adb.DeviceResultFetcher.isTestProject(DeviceResultFetcher.kt:96)
    at com.developerphil.adbidea.adb.DeviceResultFetcher.getApplicationFacets(DeviceResultFetcher.kt:63)
    at com.developerphil.adbidea.adb.DeviceResultFetcher.fetch(DeviceResultFetcher.kt:18)
    at com.developerphil.adbidea.adb.AdbFacade.executeOnDevice(AdbFacade.java:73)
    at com.developerphil.adbidea.adb.AdbFacade.clearData(AdbFacade.java:57)
    at com.developerphil.adbidea.action.ClearDataAction.actionPerformed(ClearDataAction.java:10)
    at com.developerphil.adbidea.action.AdbAction.actionPerformed(AdbAction.java:13)
    at com.intellij.openapi.actionSystem.ex.ActionUtil$1.run(ActionUtil.java:265)
    at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:282)
    at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAwareWithCallbacks(ActionUtil.java:256)
    at com.intellij.ui.popup.ActionPopupStep.performAction(ActionPopupStep.java:200)
    at com.intellij.ui.popup.ActionPopupStep.performAction(ActionPopupStep.java:190)
    at com.intellij.ui.popup.ActionPopupStep.lambda$onChosen$2(ActionPopupStep.java:184)
    at com.intellij.openapi.application.TransactionGuardImpl.performUserActivity(TransactionGuardImpl.java:192)
    at com.intellij.ui.popup.AbstractPopup.lambda$dispose$13(AbstractPopup.java:1428)
    at com.intellij.util.ui.UIUtil.invokeLaterIfNeeded(UIUtil.java:2458)
    at com.intellij.ide.IdeEventQueue.ifFocusEventsInTheQueue(IdeEventQueue.java:167)
    at com.intellij.ide.IdeEventQueue.executeWhenAllFocusEventsLeftTheQueue(IdeEventQueue.java:119)
    at com.intellij.openapi.wm.impl.FocusManagerImpl.doWhenFocusSettlesDown(FocusManagerImpl.java:161)
    at com.intellij.openapi.wm.impl.IdeFocusManagerImpl.doWhenFocusSettlesDown(IdeFocusManagerImpl.java:58)
    at com.intellij.ui.popup.AbstractPopup.dispose(AbstractPopup.java:1424)
    at com.intellij.ui.popup.WizardPopup.dispose(WizardPopup.java:162)
    at com.intellij.ui.popup.list.ListPopupImpl.dispose(ListPopupImpl.java:318)
    at com.intellij.ui.popup.PopupFactoryImpl$ActionGroupPopup.dispose(PopupFactoryImpl.java:278)
    at com.intellij.openapi.util.Disposer$1.execute(Disposer.java:47)
    at com.intellij.openapi.util.Disposer$1.execute(Disposer.java:43)
    at com.intellij.openapi.util.objectTree.ObjectNode$1.execute(ObjectNode.java:135)
    at com.intellij.openapi.util.objectTree.ObjectNode$1.execute(ObjectNode.java:104)
    at com.intellij.openapi.util.objectTree.ObjectTree.executeActionWithRecursiveGuard(ObjectTree.java:194)
    at com.intellij.openapi.util.objectTree.ObjectNode.execute(ObjectNode.java:104)
    at com.intellij.openapi.util.objectTree.ObjectTree.executeAll(ObjectTree.java:142)
    at com.intellij.openapi.util.Disposer.dispose(Disposer.java:136)
    at com.intellij.openapi.util.Disposer.dispose(Disposer.java:132)
    at com.intellij.ui.popup.WizardPopup.disposeAllParents(WizardPopup.java:263)
    at com.intellij.ui.popup.list.ListPopupImpl.handleNextStep(ListPopupImpl.java:453)
    at com.intellij.ui.popup.list.ListPopupImpl._handleSelect(ListPopupImpl.java:407)
    at com.intellij.ui.popup.list.ListPopupImpl.handleSelect(ListPopupImpl.java:348)
    at com.intellij.ui.popup.list.ListPopupImpl$1.actionPerformed(ListPopupImpl.java:261)
    at com.intellij.ui.popup.WizardPopup.proceedKeyEvent(WizardPopup.java:378)
    at com.intellij.ui.popup.WizardPopup.dispatch(WizardPopup.java:358)
    at com.intellij.ui.popup.PopupDispatcher.dispatchKeyEvent(PopupDispatcher.java:112)
    at com.intellij.ui.popup.PopupDispatcher.dispatch(PopupDispatcher.java:148)
    at com.intellij.ide.IdePopupManager.dispatch(IdePopupManager.java:93)
    at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:707)
    at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:405)
    at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:704)
    at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:404)
    at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:205)
    at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
    at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
    at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
    at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
pbreault commented 4 years ago

Thanks for the report, I should have a fix ready for that over the weekend

pbreault commented 4 years ago

Fixed in 1.5.4

AllanWang commented 4 years ago

@pbreault I'm having a similar problem. I see that you've simply removed usage of the manifest method. Do you know why it's removed?

The android plugin source seems to still have the method:

https://android.googlesource.com/platform/tools/adt/idea/+/master/android/src/org/jetbrains/android/facet/AndroidFacet.java#783

AllanWang commented 4 years ago

Linking to YouTrack bug report: https://youtrack.jetbrains.com/issue/IDEA-227310

andrei-kuznetsov commented 4 years ago

Short version: This method was removed in this commit: https://android.googlesource.com/platform/tools/adt/idea/+/2ec88db21c92b40c2355cb643bb9b4129d783ae8

Long version: see https://youtrack.jetbrains.com/issue/IDEA-227310