search

pbreault / adb-idea

A plugin for Android Studio and Intellij IDEA that speeds up your day to day android development.
Apache License 2.0
2.1k stars 256 forks source link

Fixed critical code error and update develop.md #122

Closed VovaStelmashchuk closed 4 years ago

VovaStelmashchuk commented 4 years ago

Change in develop.md:

  1. Remove html block from
  2. Update instruction

What do you think about add some CI to the project? CI not to allow merge broken code in master.

I can implement CI using GitHub action. I recomend the following steps for CI:

  1. Run gradle buildPlugin
  2. Run unit tests.
pbreault commented 4 years ago

Thanks for the PR! The documentation didn't get much love recently. Any improvement is much appreciated.

Regarding the compilation error in Debugger.kt, the reason why it fails is that project expects Android Studio 4.1. It's great that you found that because that's the reason why the debugger fails to attach on 3.6. I'll merge your PR as is but I'll make some changes to support all versions using reflection.

pbreault commented 4 years ago

Regarding CI, this has been on my mind for a while but I don't have a good solution for it. The main problem is that this project requires a valid installation of android studio to target the latest version, we can't just add a dependency on the android plugin in gradle-intellij-plugin as that won't cover neither alpha or beta builds. Any CI solution (CircleCI would be my first choice) would need to download an Android Studio distribution and unzip it, and it's unclear wether or not the terms allows for it.