search

pbreault / adb-idea

A plugin for Android Studio and Intellij IDEA that speeds up your day to day android development.
Apache License 2.0
2.12k stars 257 forks source link

Upgrade jetbrains plugin, kotlin #72

Closed fmatosqg closed 7 years ago

fmatosqg commented 7 years ago

I was trying to make some code/feature changes, but got repeatedly stuck when downloading Idea.

This resulted in being forced to bump intellij plugin version, which forced me to bump kotlin version. Good news is now it's not necessary to download any Idea versions if they won't be used for compiling or running.

There's a known problem when ./gradlew buildPlugin which fails to compile. However if run twice it works. Unfortunately I can't reproduce the problem on master, because it's being impossible for me to download Idea, it always times out.

Compiling and dry-run are good for 2.4 preview 7 and 3.0 preview 8. There's a minor code change necessary though, I'm not sure whether merging this is a good idea, but you have far more experience in backwards compatibility than me.

pbreault commented 7 years ago

Excellent! Thanks for that, the new gradle plugin is cleaner! Just a couple of comments and I'll merge it.

fmatosqg commented 7 years ago

I think keeping intellij.localPath is better because it skips the unnecessary IDEA download. Other than that I rolled back the assignment value.

I also added a new commit that fixes a problem I experienced with ./gradlew clean compileJava, now it's successful in the first try. And removed the compile.exclude module, I faintly remember that was used to solve the problem with duplicated dependencies (from forced IDEA idea.jar and AS idea.jar). Duplication should not be a problem anymore, solved by using the new intellij plugin that skips the download.

pbreault commented 7 years ago

Looking good, thank you!