Missing dependencies, better prompts and messages, nicer progress bars

pbrisbin / aurget

A simple pacman-like interface to the AUR

GNU General Public License v2.0

69 stars 17 forks source link

Missing dependencies, better prompts and messages, nicer progress bars #4

Closed ehird closed 13 years ago

ehird commented 13 years ago

These commits:

Add the dependency on sudo to the PKGBUILD.
Improve the formatting of prompts and messages slightly to be more consistent with pacman.
Avoid prompting about the PKGBUILD again before building if it was already reviewed before sourcing (my biggest annoyance with aurget which drove me to yaourt).
Use curl instead of wget for downloads; the big win here is that instead of ten or so junk lines per download, aurget just prints a simple, one-line progress bar; this adds another dependency, but it's a minor one, and the only thing I could find for filtering wget's output down to just the progress bar was extremely ugly.

I'd appreciate it if you took a look at these :)

pbrisbin commented 13 years ago

Thanks for this patch. Just a few comments:

Adding sudo is unneeded. It's a core package and I choose not to put those in aur depends.
I've been holding off on adding curl for the (probably silly) reason that I liked that aurget had no deps

I'll probably cherry pick the other two commits -- I haven't decided on curl yet...

Edit: I see curl is now in [core] too. I don't think that was always the case. I blame @falconindy

ehird commented 13 years ago

Not quite: consider

if ! curl -fso "$pkgbuild" "$aur/packages/$(url_encode "$1/$1")/PKGBUILD"; then

which isn't a GET parameter.

ehird commented 13 years ago

pbrisbin: Huh? I thought the rule was to avoid dependencies on base, not [core]. [core] contains lots of things; if aurget doesn't work without base + its dependencies installed, then that sounds like a clear packaging bug to me...

Edit: Well, "lots of things" may be a bit much :) But more than base, anyway.

falconindy commented 13 years ago

Ah true. For grabbing PKGBUILDs directly it'll fail.

pbrisbin commented 13 years ago

As this was the second time people have been commented about my improper (for some definition of improper) opinion on [core] deps. I think I'll just give in.

sudo should probably be an opt-dep since it's not strictly required. Would have to change the default config though to use su, and that'd likely break people. I'll also need to add ca-certificates since aur is now https.

Merging this for now -- leaving other stuff as a TODO.

Thanks