search

pbrisbin / aurget

A simple pacman-like interface to the AUR
GNU General Public License v2.0
69 stars 17 forks source link

Reformat code using shfmt #75

Closed aragon999 closed 5 years ago

aragon999 commented 5 years ago

Thank you for merging.

To avoid future unnecessary commits and really see useful corrections (and of course to have a nice formatted code), I ran shfmt. I used the same options as restyled.io would use, i.e. shfmt -i 2 -w -ci aurget

Furthermore I quickly looked through the output of shellcheck, there are some things which could be optimized, would you be open, to accept such a pull request?

pbrisbin commented 5 years ago

Oh my goodness, thank you so much. I was planning to do this myself, to make contributions less noisy for others -- so happy to see you go for it.

there are some things which could be optimized, would you be open, to accept such a pull request?

Yes definitely. I haven't looked at the specific issues yet, so I may have some thoughts on perhaps ignoring some or resolving one way or another -- but opening up a PR would be a good first step.

I think Code Climate is wired up correctly now (it wasn't before), so we should be avoiding new ones coming in an get a nice, satisfying "Fixed N Issues" on the PR that addresses the existing ones :)

aragon999 commented 5 years ago

You are welcome :-) Happy that I can contribute something back to a tool I have used for such a long time. I know these types of tasks, not really hard to do, but one cannot find time to do them.

Yes definitely. I haven't looked at the specific issues yet, so I may have some thoughts on perhaps ignoring some or resolving one way or another -- but opening up a PR would be a good first step.

Okay, I will look into that.

I think Code Climate is wired up correctly now (it wasn't before), so we should be avoiding new ones coming in an get a nice, satisfying "Fixed N Issues" on the PR that addresses the existing ones :)

Very nice :-)