Make appVersion Text instead of Data.Version.Version

pbrisbin / bugsnag-haskell

Bugsnag error reporter for Haskell

10 stars 7 forks source link

Make appVersion Text instead of Data.Version.Version #29

Closed MaxGabriel closed 6 years ago

MaxGabriel commented 6 years ago

This allows using e.g. Git SHAs as the version, for users who deploy on every commit instead of assigning version numbers
This better reflects Bugsnag's API which allows for arbitrary version numbers, without an a.b.c convention

pbrisbin commented 6 years ago

Hey thanks! This LGTM. I don't know why Circle ignored it (I do have "Build Forked Pull Requests" enabled). Do you mind doing a quick amend+force-push, to see if Circle notices it?

MaxGabriel commented 6 years ago

Ok, I force pushed an amended commit. Not sure if that'll trigger CI though

MaxGabriel commented 6 years ago

Doesn't seem to have worked 🤷‍♀️

pbrisbin commented 6 years ago

Weird. Thanks anyway.