search

pbrisbin / bugsnag-haskell

Bugsnag error reporter for Haskell
10 stars 7 forks source link

Remove bsFilterStackFrames #32

Closed pbrisbin closed 6 years ago

pbrisbin commented 6 years ago

This can just be a BeforeNotify, no need for a separate setting.

pbrisbin commented 6 years ago

bsIsInProject can probably be removed to.

Once we provide the right BeforeNotify helpers, instead of:

bsFilterStackFrames = f
bsIsInProject = g

One could do:

bsBeforeNotify =
  defaultBeforeNotify
    . filterStackFrames f
    . setIsInProject g

And we can trim all the special handling of those two settings.

pbrisbin commented 6 years ago

bsGroupingHash too!

pbrisbin commented 6 years ago

These functions are marked deprecated as of v.0.0.1.3 and will be removed before we hit 1.0.