search

pbrune1973 / qwics

Other
6 stars 0 forks source link

fix issues found by SpotBugs, including infinite recursive loops #7

Closed GitMensch closed 5 years ago

GitMensch commented 5 years ago

As you use Eclipse I suggest to get the SpotBugs extension.

Those are the markers it sets:

Description Resource Path Location Type
new java.sql.SQLException(Throwable) not thrown in org.qwics.jdbc.QwicsDataSource.getConnection() [Scariest(1), High confidence] QwicsDataSource.java /QwicsJDBCDriver/src/org/qwics/jdbc line 137 SpotBugs Problem (Scariest)
new java.sql.SQLException(Throwable) not thrown in org.qwics.jdbc.QwicsDataSource.getPooledConnection() [Scariest(1), High confidence] QwicsDataSource.java /QwicsJDBCDriver/src/org/qwics/jdbc line 154 SpotBugs Problem (Scariest)
new java.sql.SQLException(Throwable) not thrown in org.qwics.jdbc.QwicsXADataSource.getXAConnection() [Scariest(1), High confidence] QwicsXADataSource.java /QwicsJDBCDriver/src/org/qwics/jdbc line 72 SpotBugs Problem (Scariest)
Impossible downcast of toArray() result to javax.transaction.xa.Xid[] in org.qwics.jdbc.QwicsXAResource.recover(int) [Scary(5), High confidence] QwicsXAResource.java /QwicsJDBCDriver/src/org/qwics/jdbc line 154 SpotBugs Problem (Scary)
Impossible downcast of toArray() result to javax.transaction.xa.Xid[] in org.qwics.jdbc.QwicsXAResource.recover(int) [Scary(5), High confidence] QwicsXAResource.java /QwicsJDBCDriver/src/org/qwics/jdbc line 168 SpotBugs Problem (Scary)
Invocation of toString on x in org.qwics.jdbc.QwicsMapResultSet.updateBytes(int, byte[]) [Scary(8), High confidence] QwicsMapResultSet.java /QwicsJDBCDriver/src/org/qwics/jdbc line 787 SpotBugs Problem (Scary)
Invocation of toString on x in org.qwics.jdbc.QwicsMapResultSet.updateBytes(String, byte[]) [Scary(8), High confidence] QwicsMapResultSet.java /QwicsJDBCDriver/src/org/qwics/jdbc line 894 SpotBugs Problem (Scary)
There is an apparent infinite recursive loop in org.qwics.jdbc.QwicsXid.getFormatId() [Scary(9), High confidence] QwicsXid.java /QwicsJDBCDriver/src/org/qwics/jdbc line 103 SpotBugs Problem (Scary)
There is an apparent infinite recursive loop in org.qwics.jdbc.QwicsXid.getGlobalTransactionId() [Scary(9), High confidence] QwicsXid.java /QwicsJDBCDriver/src/org/qwics/jdbc line 108 SpotBugs Problem (Scary)
pbrune1973 commented 5 years ago

Thanks for the hint, I cross-checked and fixed the issues raised by SpotBugs in the master branch.