search

pbs-assess / csasdown

:book: An R package for creating CSAS reports in PDF or Word format with R Markdown and bookdown
Other
47 stars 17 forks source link

Finish merging fsar branch into main #265

Closed seananderson closed 2 months ago

seananderson commented 2 months ago

Start by importing several packages for fsar_plot_base.

importFrom("grDevices", "grey")
     importFrom("graphics", "axis", "box", "layout", "legend", "lines",
                "mtext", "par")
     importFrom("stats", "arima.sim", "rnorm")

Also 

Found the following file with non-ASCII characters:
     R/plot-timeseries.R
   Portable packages must use only ASCII characters in their R code and
   NAMESPACE directives, except perhaps in comments.
   Use \uxxxx escapes for other characters.
   Function ‘tools::showNonASCIIfile’ can help in finding non-ASCII

and

checking Rd \usage sections ...
   Undocumented arguments in Rd file 'fsar_plot_base.Rd'
     ‘in.df’
   Documented arguments not in \usage in Rd file 'fsar_plot_base.Rd':
     ‘timeseries’

   Undocumented arguments in Rd file 'fsar_plot_ggplot.Rd'
     ‘df’
   Documented arguments not in \usage in Rd file 'fsar_plot_ggplot.Rd':
     ‘timeseries’

and

   > fsar_plot_ggplot(sim_fsar_data(format="wide"))
   Error in expansion(mult = c(0, 0.02)) : 
     could not find function "expansion"

and

 checking for portable file names ...
   Found the following files with non-portable file names:
     inst/csas-docx/FSAR FSRR Template-eng 231109.docx
     inst/csas-docx/FSAR FSRR Template-eng 231212.docx
     inst/csas-docx/FSAR FSRR Template-eng 240219.docx
     inst/csas-docx/P-AS P-RS Gabarit-fr 231109.docx
     inst/csas-docx/P-AS P-RS Gabarit-fr 240219.docx
   These are not fully portable file names.
seananderson commented 2 months ago

OK, the fsar branch is merged into the main branch. Note that I pulled the fsar plotting and simulation demo functions out of the package and into .R files within the fsar template folder. They would require a lot of package imports and are probably more useful as source code anyways. @PaulRegular @ricardd